kip-249: sync AuctionTx with the v3.0 AuctionEntryPoint - #128
Open
hyunsooda wants to merge 1 commit into
Open
Conversation
Add the searcher-signed maxGasPrice field (typehash, EIP-712 types, struct, domain version 0.0.2) and its effective-gas-price ceiling check, and note that call() reverts before the backrun if less than callGasLimit gas remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs KIP-249 with the deployed v3.0 AuctionEntryPoint.
maxGasPricefield to the typehash, EIP-712 types,AuctionTxstruct, andBidDetails; bump the domain version to0.0.2; add theeffectiveGasPrice <= maxGasPricecheck to the proposer and auctioneer verification.call()reverts before the backrun if less thancallGasLimitgas remains, so a searcher is charged only when the backrun receives the signed gas.