feat: remove CacheSetError, rename TtlSortedCache insert* to set*, wrap order-method values in CacheValue - #293
Merged
Conversation
…et*`, wrap order-method values in `CacheValue` Breaking changes ahead of 3.0.0 final: - remove `CacheSetError`: a TTL that would overflow `Instant` bounds now stores the entry with no expiry (never expires) on every set path, matching the sharded TTL stores (`cache_set` already behaved this way). `TtlCache` / `LruTtlCache` / `TtlSortedCache` set `Cached::Error = Infallible`, so every built-in in-memory store is infallible; the `type Error` machinery remains for custom and IO stores. - rename `TtlSortedCache::insert` / `insert_ttl` / `insert_evict` / `insert_ttl_evict` to `set` / `set_with_ttl` / `set_evict` / `set_with_ttl_evict`, returning `Option<V>` instead of `Result`. - unify the LRU-family order methods on one shape: `iter_order() -> Vec<(K, CacheValue<V, M>)>` and `value_order() -> Vec<CacheValue<V, M>>` on `LruCache`, `LruTtlCache`, and `ExpiringLruCache`. `CacheValue<V, M = ()>` (new root re-export) derefs to `V`, compares against bare values, and exposes per-entry metadata via typed accessors: `expires_at()` on `LruTtlCache` entries (`M = Option<Instant>`). `LruTtlCache` no longer leaks bare `(Option<Instant>, V)` tuples. Migration guide sections 18/22/33/43 updated and 74/75 added; design doc 0020 closed out (error split kept, `TimeBounds` gone).
jaemk
added a commit
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes ahead of 3.0.0 final.
CacheSetError: a TTL that would overflowInstantbounds now stores the entry with no expiry (never expires) on every set path, matching the sharded TTL stores (cache_setalready behaved this way).TtlCache/LruTtlCache/TtlSortedCachesetCached::Error = Infallible, so every built-in in-memory store is infallible;type Errorremains for custom and IO stores.TtlSortedCache::insert/insert_ttl/insert_evict/insert_ttl_evicttoset/set_with_ttl/set_evict/set_with_ttl_evict, returningOption<V>instead ofResult.iter_order() -> Vec<(K, CacheValue<V, M>)>andvalue_order() -> Vec<CacheValue<V, M>>onLruCache,LruTtlCache, andExpiringLruCache.CacheValue<V, M = ()>(new root re-export) derefs toV, compares against bare values (PartialEq<V>), and exposesexpires_at()onLruTtlCacheentries (M = Option<Instant>).LruTtlCacheno longer leaks bare(Option<Instant>, V)tuples.TimeBoundsgone).