Skip to content

feature/524_add-version-to-help-text#525

Merged
redcatbear merged 22 commits into
mainfrom
feature/524_add-version-to-help-text
May 30, 2026
Merged

feature/524_add-version-to-help-text#525
redcatbear merged 22 commits into
mainfrom
feature/524_add-version-to-help-text

Conversation

@redcatbear
Copy link
Copy Markdown
Collaborator

Close #524.

@redcatbear redcatbear self-assigned this May 26, 2026
@redcatbear redcatbear requested a review from kaklakariada May 26, 2026 11:12
Copy link
Copy Markdown
Collaborator Author

@redcatbear redcatbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a prereview of my own changes. I found a broken skill link in the process. Hence the skill changes that have nothing to do with this PR per-se.

Comment thread .agents/skills/openfasttrace-spec-driven-development/SKILL.md
Comment thread .agents/skills/openfasttrace/skill.md Outdated
Comment thread .agents/skills/openfasttrace/skill.md Outdated
Comment thread .agents/skills/openfasttrace/skill.md Outdated
Comment thread core/src/main/resources/usage.txt
Comment thread core/src/test/java/org/itsallcode/openfasttrace/core/VersionProviderIT.java Outdated
Comment thread core/pom.xml
Comment thread doc/spec/design.md Outdated
Comment thread doc/spec/design.md Outdated
Comment thread doc/spec/design.md

Rationale:

This makes the `revision` the single source of truth for the version of OpenFastTrace and avoids having to keep manually maintained copies of the version information.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can also explain why we don't use something like

        final VersionCollector versionCollector = new VersionCollector(
                "META-INF/maven/com.exasol/mysql-virtual-schema/pom.properties");
        return versionCollector.getVersionNumber();

(e.g. https://github.com/exasol/mysql-virtual-schema/blob/main/src/main/java/com/exasol/adapter/dialects/mysql/MySQLSqlDialectFactory.java#L22-L24)

Possible rationale: doesn't work at build time during unit tests.

kaklakariada and others added 2 commits May 30, 2026 16:21
Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
58.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@redcatbear redcatbear merged commit 8633356 into main May 30, 2026
10 of 11 checks passed
@redcatbear redcatbear deleted the feature/524_add-version-to-help-text branch May 30, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add version to help text

2 participants