feature/524_add-version-to-help-text#525
Merged
Merged
Conversation
redcatbear
commented
May 26, 2026
Collaborator
Author
redcatbear
left a comment
There was a problem hiding this comment.
I did a prereview of my own changes. I found a broken skill link in the process. Hence the skill changes that have nothing to do with this PR per-se.
kaklakariada
requested changes
May 27, 2026
kaklakariada
approved these changes
May 30, 2026
kaklakariada
requested changes
May 30, 2026
|
|
||
| Rationale: | ||
|
|
||
| This makes the `revision` the single source of truth for the version of OpenFastTrace and avoids having to keep manually maintained copies of the version information. |
Contributor
There was a problem hiding this comment.
If you want, you can also explain why we don't use something like
final VersionCollector versionCollector = new VersionCollector(
"META-INF/maven/com.exasol/mysql-virtual-schema/pom.properties");
return versionCollector.getVersionNumber();Possible rationale: doesn't work at build time during unit tests.
Co-authored-by: Christoph Pirkl <4711730+kaklakariada@users.noreply.github.com>
kaklakariada
approved these changes
May 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Close #524.