Add missing selector to factory service#358
Open
simonfernandes wants to merge 1 commit into
Open
Conversation
simonfernandes
requested review from
a team and
ellen-wright
and removed request for
a team
ACLay
approved these changes
Jun 26, 2026
William-Edwards-STFC
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix for the intermittent dev factory problems since moving to gitops:
This selector field was missing from the service yaml, and so the service was not routing traffic to the pod. I've applied it manually to the fallback cluster to test and it's working with this fix.
It sounds like this wasn't needed before because the main dev cluster had the selector either from an older version of it or set manually at some point, and it had never been re-applied. Though I'm unsure why we didn't see problems with the fallback cluster when the factory was in docker-orchestration and deployed to both clusters.