feat: Add Internxt Virtual Drive extension for Nemo file manager - #409
feat: Add Internxt Virtual Drive extension for Nemo file manager#409egalvis27 wants to merge 7 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds generic Nautilus, Nemo, and Dolphin detection, file-manager extension lifecycle management, persisted extension versions, sharing-link generation, Nemo virtual-drive integration, smoke testing, and generic availability reporting through IPC and the renderer. ChangesFile-manager extension support
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant App
participant FileManagerDetection
participant ExtensionInstaller
participant FileManagerService
participant FileManager
App->>ExtensionInstaller: installFileManagerExtension()
ExtensionInstaller->>FileManagerDetection: detectAvailableFileManager()
ExtensionInstaller->>FileManagerService: copy or replace extension
ExtensionInstaller->>FileManagerService: persist fileManagerExtensionVersion
ExtensionInstaller->>FileManager: reload detected manager
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.tsx (1)
12-18: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winComplete the migration from Nautilus-specific terminology.
The new contract is file-manager agnostic, but the UI and tests still describe only Nautilus.
src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.tsx#L12-L18: rename the state/copy to generic file-manager terminology.src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.test.tsx#L9-L20: update test descriptions to refer to supported file managers rather than Nautilus.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.tsx` around lines 12 - 18, Complete the terminology migration in NautilusUnavailable.tsx by renaming Nautilus-specific state and user-facing copy to generic file-manager terminology while preserving behavior. In NautilusUnavailable.test.tsx, update test descriptions and assertions that reference Nautilus to describe supported file managers; apply the requested changes at both listed files and ranges.
🧹 Nitpick comments (3)
src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.test.tsx (1)
9-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRename the test descriptions to match the generic API.
These tests now exercise
getFileManagerAvailability, so titles such as “when Nautilus is available” are misleading. Use “when a supported file manager is available/unavailable” to keep the tests aligned with the new contract.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.test.tsx` around lines 9 - 20, Rename the two test descriptions in the NautilusUnavailable test suite to refer to “a supported file manager” being available or unavailable, matching the getFileManagerAvailability API contract while leaving the test behavior unchanged.assets/python-nemo/internxt-virtual-drive.py (2)
76-76: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove unnecessary semicolon.
Python does not require semicolons to terminate statements.
♻️ Proposed refactor
- file_uri = file.get_uri(); + file_uri = file.get_uri()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@assets/python-nemo/internxt-virtual-drive.py` at line 76, Remove the unnecessary semicolon from the file.get_uri() statement in the surrounding code, keeping the assignment behavior unchanged.Source: Linters/SAST tools
80-80: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove unnecessary semicolon.
Python does not require semicolons to terminate statements.
♻️ Proposed refactor
- file_uri = file.get_uri(); + file_uri = file.get_uri()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@assets/python-nemo/internxt-virtual-drive.py` at line 80, Remove the unnecessary semicolon from the statement assigning the URI in the surrounding file-handling code, leaving the file.get_uri() call and resulting assignment unchanged.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/python-nemo/internxt-virtual-drive.py`:
- Line 106: Update all external requests calls in
assets/python-nemo/internxt-virtual-drive.py to include a reasonable timeout,
such as 2 seconds: requests.get in _get_availability (106-106), requests.post in
_make_locally_available (195-195) and _copy_internxt_link (208-208), and
requests.delete in _make_remote_only (240-240). Ensure every listed call uses
the timeout consistently.
- Around line 175-181: Update _encode_file_path to URL-decode file.get_uri()
before deriving the relative path, then remove self.root_folder from the decoded
value instead of replacing self.file_base_dir on the encoded URI. Preserve the
existing UTF-8 and base64 encoding flow.
In `@src/backend/features/file-manager-extension/install.ts`:
- Around line 59-66: Update the installed-version replacement flow around
deleteExtensionFile and install so the new extension is first staged in the
destination directory, then atomically renamed over the existing extension only
after installation succeeds. Preserve the current working extension when staging
or copying fails, and remove the pre-install deletion step.
In `@src/backend/features/file-manager-extension/service.ts`:
- Around line 89-97: Update deleteExtensionFile to clean up both known
file-manager destination paths instead of relying on getFileManagerConfig’s
currently detected manager. Enumerate the Nautilus and Nemo destinations, check
each with doesFileExist, and remove every existing extension file via fs.rm
while preserving the no-op behavior when neither is installed.
- Around line 110-128: Update the Promise wrapping the reload command in the
file-manager reload service to enforce a short timeout for the exec process.
When the timeout is exceeded, terminate the child process if possible and reject
the Promise, while preserving the existing handling for exit code 255, stderr,
and successful completion.
---
Outside diff comments:
In `@src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.tsx`:
- Around line 12-18: Complete the terminology migration in
NautilusUnavailable.tsx by renaming Nautilus-specific state and user-facing copy
to generic file-manager terminology while preserving behavior. In
NautilusUnavailable.test.tsx, update test descriptions and assertions that
reference Nautilus to describe supported file managers; apply the requested
changes at both listed files and ranges.
---
Nitpick comments:
In `@assets/python-nemo/internxt-virtual-drive.py`:
- Line 76: Remove the unnecessary semicolon from the file.get_uri() statement in
the surrounding code, keeping the assignment behavior unchanged.
- Line 80: Remove the unnecessary semicolon from the statement assigning the URI
in the surrounding file-handling code, leaving the file.get_uri() call and
resulting assignment unchanged.
In
`@src/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.test.tsx`:
- Around line 9-20: Rename the two test descriptions in the NautilusUnavailable
test suite to refer to “a supported file manager” being available or
unavailable, matching the getFileManagerAvailability API contract while leaving
the test behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 848e88cd-965e-4df2-83ac-968d7767f691
📒 Files selected for processing (23)
assets/python-nemo/internxt-virtual-drive.pyknip.jsonsrc/apps/main/auth/service.test.tssrc/apps/main/config.tssrc/apps/main/config/save-config.tssrc/apps/main/interface.d.tssrc/apps/main/preload.d.tssrc/apps/main/preload.jssrc/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.test.tsxsrc/apps/renderer/pages/Widget/InfoBanners/Banners/NautilusUnavailable.tsxsrc/backend/features/file-manager-extension/detect-available.test.tssrc/backend/features/file-manager-extension/detect-available.tssrc/backend/features/file-manager-extension/install.test.tssrc/backend/features/file-manager-extension/install.tssrc/backend/features/file-manager-extension/service.test.tssrc/backend/features/file-manager-extension/service.tssrc/backend/features/file-manager-extension/version.tssrc/core/bootstrap/register-app-ready-flow.tssrc/core/bootstrap/register-main-ipc-handlers.tssrc/core/bootstrap/register-session-event-handlers.tssrc/core/electron/store/app-store.interface.tssrc/core/electron/store/defaults.tsvitest.setup.main.ts
| if (installed && !hasLatestVersion) { | ||
| logger.debug({ | ||
| msg: '[FILE_MANAGER_EXTENSION] There is a newer version to be installed', | ||
| }); | ||
|
|
||
| await deleteExtensionFile(); | ||
| await install(); | ||
| await reloadFileManager().catch((reloadError) => { |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Do not delete the working extension before staging its replacement.
If install() fails after Line 64, the previous extension is already gone. Stage the new asset in the destination directory and atomically rename it over the existing file, preserving the old version if copying fails.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/backend/features/file-manager-extension/install.ts` around lines 59 - 66,
Update the installed-version replacement flow around deleteExtensionFile and
install so the new extension is first staged in the destination directory, then
atomically renamed over the existing extension only after installation succeeds.
Preserve the current working extension when staging or copying fails, and remove
the pre-install deletion step.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/backend/features/file-manager-extension/service.test.ts (2)
80-114: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winAssert the manager-specific extension path.
These tests only control
doesFileExist’s return value, so they would still pass if Nautilus and Nemo used the wrong or shared path. Assert the exact expected path for each manager (and that no path check occurs when no manager is available).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/backend/features/file-manager-extension/service.test.ts` around lines 80 - 114, Add assertions to the isInstalled tests verifying that doesFileExistMock receives the exact manager-specific extension path for Nautilus and Nemo. Also cover the no-manager case and assert that doesFileExistMock is not called, while preserving the existing boolean result assertions.
132-138: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winMake the
execmocks honor the child-process contract.
reloadFileManager()attaches anerrorlistener to the object returned byexec. These mocks invoke the callback synchronously and return nothing, so the promise may resolve before the invalidchildProcess.on(...)call occurs. Return an EventEmitter-like object and invoke the callback afterexecMockreturns; otherwise these tests can mask regressions in the reload setup.This test double should match the
reloadFileManager()contract insrc/backend/features/file-manager-extension/service.ts:104-138.Suggested mock shape
execMock.mockImplementation((cmd, optionsOrCallback, callback) => { const cb = typeof optionsOrCallback === 'function' ? optionsOrCallback : callback; - cb?.(null, '', ''); + const childProcess = { on: vi.fn() }; + queueMicrotask(() => cb?.(null, '', '')); + return childProcess; });Also applies to: 150-156, 168-174, 201-204
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/backend/features/file-manager-extension/service.test.ts` around lines 132 - 138, Update every execMock implementation in the affected tests to return an EventEmitter-like child-process object supporting the error listener used by reloadFileManager(), and defer callback invocation until after execMock returns. Preserve each test’s existing command, options, and callback assertions while ensuring the mock matches the reloadFileManager() child-process contract.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/backend/features/file-manager-extension/service.test.ts`:
- Around line 80-114: Add assertions to the isInstalled tests verifying that
doesFileExistMock receives the exact manager-specific extension path for
Nautilus and Nemo. Also cover the no-manager case and assert that
doesFileExistMock is not called, while preserving the existing boolean result
assertions.
- Around line 132-138: Update every execMock implementation in the affected
tests to return an EventEmitter-like child-process object supporting the error
listener used by reloadFileManager(), and defer callback invocation until after
execMock returns. Preserve each test’s existing command, options, and callback
assertions while ensuring the mock matches the reloadFileManager() child-process
contract.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 00664aa5-5a11-435e-a849-56093e524cd2
📒 Files selected for processing (1)
src/backend/features/file-manager-extension/service.test.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/backend/features/file-manager-extension/create-sharing-link/generate-link.ts`:
- Around line 22-33: Handle a null result from fetchRandomDomain before
generating the code or calling createSharingResult: return the flow’s existing
error response immediately when no domain is available, and preserve the current
sharing-link generation path for valid domains.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f042ef24-c340-406b-8a29-a165a09e1a35
📒 Files selected for processing (27)
src/apps/drive/hydration-api/controllers/contents.test.tssrc/apps/drive/hydration-api/controllers/contents.tssrc/apps/main/auth/service.test.tssrc/apps/main/config.tssrc/apps/main/config/save-config.tssrc/backend/features/file-manager-extension/create-sharing-link/create-sharing-result.test.tssrc/backend/features/file-manager-extension/create-sharing-link/create-sharing-result.tssrc/backend/features/file-manager-extension/create-sharing-link/fetch-random-domain.test.tssrc/backend/features/file-manager-extension/create-sharing-link/fetch-random-domain.tssrc/backend/features/file-manager-extension/create-sharing-link/generate-link.test.tssrc/backend/features/file-manager-extension/create-sharing-link/generate-link.tssrc/backend/features/file-manager-extension/create-sharing-link/resolve-shareable-item.test.tssrc/backend/features/file-manager-extension/create-sharing-link/resolve-shareable-item.tssrc/backend/features/file-manager-extension/create-sharing-link/types.tssrc/backend/features/nautilus-extension/install.test.tssrc/backend/features/nautilus-extension/install.tssrc/backend/features/nautilus-extension/is-nautilus-available.test.tssrc/backend/features/nautilus-extension/is-nautilus-available.tssrc/backend/features/nautilus-extension/reload.test.tssrc/backend/features/nautilus-extension/reload.tssrc/backend/features/nautilus-extension/service.test.tssrc/backend/features/nautilus-extension/service.tssrc/backend/features/nautilus-extension/uninstall.test.tssrc/backend/features/nautilus-extension/uninstall.tssrc/backend/features/nautilus-extension/version.tssrc/core/electron/store/app-store.interface.tssrc/core/electron/store/defaults.ts
💤 Files with no reviewable changes (14)
- src/backend/features/nautilus-extension/install.test.ts
- src/apps/main/config.ts
- src/backend/features/nautilus-extension/service.test.ts
- src/backend/features/nautilus-extension/uninstall.ts
- src/backend/features/nautilus-extension/is-nautilus-available.ts
- src/backend/features/nautilus-extension/reload.ts
- src/backend/features/nautilus-extension/service.ts
- src/backend/features/nautilus-extension/reload.test.ts
- src/backend/features/nautilus-extension/uninstall.test.ts
- src/backend/features/nautilus-extension/is-nautilus-available.test.ts
- src/backend/features/nautilus-extension/install.ts
- src/apps/main/config/save-config.ts
- src/backend/features/nautilus-extension/version.ts
- src/apps/main/auth/service.test.ts
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/backend/features/file-manager-extension/create-sharing-link/generate-link.ts`:
- Around line 22-33: Handle a null result from fetchRandomDomain before
generating the code or calling createSharingResult: return the flow’s existing
error response immediately when no domain is available, and preserve the current
sharing-link generation path for valid domains.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f042ef24-c340-406b-8a29-a165a09e1a35
📒 Files selected for processing (27)
src/apps/drive/hydration-api/controllers/contents.test.tssrc/apps/drive/hydration-api/controllers/contents.tssrc/apps/main/auth/service.test.tssrc/apps/main/config.tssrc/apps/main/config/save-config.tssrc/backend/features/file-manager-extension/create-sharing-link/create-sharing-result.test.tssrc/backend/features/file-manager-extension/create-sharing-link/create-sharing-result.tssrc/backend/features/file-manager-extension/create-sharing-link/fetch-random-domain.test.tssrc/backend/features/file-manager-extension/create-sharing-link/fetch-random-domain.tssrc/backend/features/file-manager-extension/create-sharing-link/generate-link.test.tssrc/backend/features/file-manager-extension/create-sharing-link/generate-link.tssrc/backend/features/file-manager-extension/create-sharing-link/resolve-shareable-item.test.tssrc/backend/features/file-manager-extension/create-sharing-link/resolve-shareable-item.tssrc/backend/features/file-manager-extension/create-sharing-link/types.tssrc/backend/features/nautilus-extension/install.test.tssrc/backend/features/nautilus-extension/install.tssrc/backend/features/nautilus-extension/is-nautilus-available.test.tssrc/backend/features/nautilus-extension/is-nautilus-available.tssrc/backend/features/nautilus-extension/reload.test.tssrc/backend/features/nautilus-extension/reload.tssrc/backend/features/nautilus-extension/service.test.tssrc/backend/features/nautilus-extension/service.tssrc/backend/features/nautilus-extension/uninstall.test.tssrc/backend/features/nautilus-extension/uninstall.tssrc/backend/features/nautilus-extension/version.tssrc/core/electron/store/app-store.interface.tssrc/core/electron/store/defaults.ts
💤 Files with no reviewable changes (14)
- src/backend/features/nautilus-extension/install.test.ts
- src/apps/main/config.ts
- src/backend/features/nautilus-extension/service.test.ts
- src/backend/features/nautilus-extension/uninstall.ts
- src/backend/features/nautilus-extension/is-nautilus-available.ts
- src/backend/features/nautilus-extension/reload.ts
- src/backend/features/nautilus-extension/service.ts
- src/backend/features/nautilus-extension/reload.test.ts
- src/backend/features/nautilus-extension/uninstall.test.ts
- src/backend/features/nautilus-extension/is-nautilus-available.test.ts
- src/backend/features/nautilus-extension/install.ts
- src/apps/main/config/save-config.ts
- src/backend/features/nautilus-extension/version.ts
- src/apps/main/auth/service.test.ts
🛑 Comments failed to post (1)
src/backend/features/file-manager-extension/create-sharing-link/generate-link.ts (1)
22-33: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Stop when no sharing domain is available.
fetchRandomDomain()returnsnullfor an empty list, but this flow still creates a sharing record and copiesnull/sh/...as a success. Return an error before generating or persisting the sharing.Proposed fix
const item = await resolveShareableItem({ path }); const domain = await fetchRandomDomain(); + if (!domain) { + return { error: new Error('No public sharing domain is available') }; + } + const plainCode = stringUtils.generateRandomStringUrlSafe(8);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.const domain = await fetchRandomDomain(); if (!domain) { return { error: new Error('No public sharing domain is available') }; } const plainCode = stringUtils.generateRandomStringUrlSafe(8); const encryptionKey = aes.encrypt(mnemonic, plainCode); const encryptedCode = aes.encrypt(plainCode, mnemonic); const sharing = await createSharingResult({ encryptedCode, encryptionKey, item, }); const recoveredCode = aes.decrypt(sharing.encryptedCode, mnemonic); const sharingId = stringUtils.encodeV4Uuid(sharing.id); const shareLink = `${domain}/sh/${item.itemType}/${sharingId}/${recoveredCode}`;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/backend/features/file-manager-extension/create-sharing-link/generate-link.ts` around lines 22 - 33, Handle a null result from fetchRandomDomain before generating the code or calling createSharingResult: return the flow’s existing error response immediately when no domain is available, and preserve the current sharing-link generation path for valid domains.
| async function hasNautilusBinary(): Promise<boolean> { | ||
| try { | ||
| await execAsync('command -v nautilus'); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| async function hasNemoBinary(): Promise<boolean> { | ||
| try { | ||
| await execAsync('command -v nemo'); | ||
| return true; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
these 2 functions are exactly the same minus the "nemo" and "nautilus" part, why not simplify them?
| if (desktopEntry.includes('nemo.desktop')) { | ||
| if (await hasNemoBinary()) { | ||
| return 'nemo'; | ||
| } | ||
| } | ||
|
|
||
| if (desktopEntry.includes('nautilus.desktop')) { | ||
| if (await hasNautilusBinary()) { | ||
| return 'nautilus'; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You are doing 2 similar steps here, why not simplify it so the code is more readable?
| import { LATEST_EXTENSION_VERSION } from './version'; | ||
|
|
||
| function isUpToDate(): boolean { | ||
| const extensionInstalledAt = configStore.get('fileManagerExtensionVersion'); |
There was a problem hiding this comment.
The variable was named incorrectly, but it has now been corrected.
| return false; | ||
| } | ||
|
|
||
| return extensionInstalledAt >= LATEST_EXTENSION_VERSION; |
There was a problem hiding this comment.
From what I have read, you are replacing entirely the version of the old nautilusExtensionVersion to a new fileManagerExtensionVersion with no plan on "migrating", what will happen to the users that have been using the app and have the old value? that behaviour is not documented anywhere (perhaps i have overlooked it)
There was a problem hiding this comment.
There's no need to have a migration plan for existing users; all that will happen is that the extension will be reinstalled and the application will continue to function normally. The new field will be created in the settings, and the next time there's an update to the extension, that field will be used to trigger its reinstallation.
| ipcMain.handle('get-file-manager-availability', async () => { | ||
| const fileManager = await detectAvailableFileManager(); | ||
| return fileManager !== null; |
There was a problem hiding this comment.
Nit: would it make sense to expose an isFileManagerAvailable function just like we had with isNautilusAvailable and have the IPC handler delegate to it? That would keep the handler declarative.
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/file-manager-extension-smoke.yml:
- Around line 25-26: Update the actions/checkout@v4 step in the smoke-test
workflow to set persist-credentials to false, ensuring later steps cannot read
the stored GITHUB_TOKEN from Git configuration.
In `@assets/dolphin/internxt-dolphin-actions.sh`:
- Around line 14-21: Update the root validation around file_path and root_folder
to use os.path.commonpath and confirm it exactly matches root_folder before
deriving relative_path. Preserve the existing empty-output and early-exit
behavior for paths outside the root, then slice only after this component-aware
check.
- Around line 57-59: Add bounded connection and total timeouts to the curl
invocation in the copy-link request within the response hydration flow, ensuring
stalled HTTP requests cannot block the Dolphin action indefinitely while
preserving the existing silent failure and empty-response handling.
- Around line 51-58: Update encode_relative_path and the URL construction in the
copy-link request so the complete Base64 value is percent-encoded as a single
path segment before appending it to /copy-link/. Preserve the existing
empty-value exit and ensure the server receives the same decoded value through
req.params.path.
In `@package.json`:
- Line 38: Update the smoke:file-manager-extension script in package.json to
unset NODE_ENV or set it to production, ensuring copyExtensionFile() exercises
the production fs.cp installation path rather than the development fs.link path.
In `@README.md`:
- Around line 25-84: Fix the KDE Wallet section hierarchy in the README: change
“Prerequisites for KDE based distros” to an H3 sibling under Installation,
hyphenate it as “KDE-based distros,” and change “### Step 3: Configure KDE
Wallet for GPG” to H4 so it matches the other Method 2 step headings.
In `@src/backend/features/file-manager-extension/file-manager-extension-smoke.ts`:
- Around line 31-47: Replace the hardcoded path logic in getExpectedPaths with
values derived from getFileManagerConfig. In run(), await the configuration and
assert asset destinations from config.assets, including each asset’s template
and executable flags; update the Dolphin-specific checks to follow the flags on
the corresponding assets.
In `@src/backend/features/file-manager-extension/service.test.ts`:
- Around line 33-37: Restore the process-wide NODE_ENV value after each test in
the suite containing the beforeEach setup. Capture the original value before
overriding it, then restore that value in an afterEach hook while keeping the
existing mock setup unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a5777a9f-d4d3-48b8-bf1e-9546f6070d82
📒 Files selected for processing (17)
.eslintrc.js.github/workflows/file-manager-extension-smoke.ymlREADME.mdassets/dolphin/internxt-dolphin-actions.shassets/dolphin/internxt-virtual-drive.desktoppackage.jsonsrc/backend/features/file-manager-extension/constants.tssrc/backend/features/file-manager-extension/detect-available.test.tssrc/backend/features/file-manager-extension/detect-available.tssrc/backend/features/file-manager-extension/file-manager-extension-smoke.tssrc/backend/features/file-manager-extension/install.test.tssrc/backend/features/file-manager-extension/install.tssrc/backend/features/file-manager-extension/service.test.tssrc/backend/features/file-manager-extension/service.tssrc/backend/features/file-manager-extension/version.tssrc/core/electron/paths.tstests/smoke/file-manager-extension/smoke-electron-mock.cjs
💤 Files with no reviewable changes (1)
- .eslintrc.js
🚧 Files skipped from review as they are similar to previous changes (3)
- src/backend/features/file-manager-extension/install.ts
- src/backend/features/file-manager-extension/install.test.ts
- src/backend/features/file-manager-extension/version.ts
| - name: Check out Git repository | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
Disable credential persistence on checkout.
This job only reads the repository; it never pushes. Set persist-credentials: false on actions/checkout@v4 so the GITHUB_TOKEN credential isn't left in the git config for later steps (e.g., npm ci, which runs arbitrary install scripts) to read.
🔒 Proposed fix
- name: Check out Git repository
uses: actions/checkout@v4
+ with:
+ persist-credentials: false📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Check out Git repository | |
| uses: actions/checkout@v4 | |
| - name: Check out Git repository | |
| uses: actions/checkout@v4 | |
| with: | |
| persist-credentials: false |
🧰 Tools
🪛 zizmor (1.28.0)
[warning] 25-26: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/file-manager-extension-smoke.yml around lines 25 - 26,
Update the actions/checkout@v4 step in the smoke-test workflow to set
persist-credentials to false, ensuring later steps cannot read the stored
GITHUB_TOKEN from Git configuration.
Source: Linters/SAST tools
| file_path = os.path.realpath(sys.argv[1]) | ||
| root_folder = os.path.realpath(sys.argv[2]) | ||
|
|
||
| if not file_path.startswith(root_folder): | ||
| print("") | ||
| sys.exit(0) | ||
|
|
||
| relative_path = file_path[len(root_folder):] |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use a component-aware root check.
Line [17] accepts sibling paths such as /home/user/Internxt Drive Backup/file.txt. The helper then sends a path outside ROOT_FOLDER. Use os.path.commonpath before slicing the relative path.
Proposed fix
-if not file_path.startswith(root_folder):
+try:
+ is_inside_root = os.path.commonpath((file_path, root_folder)) == root_folder
+except ValueError:
+ is_inside_root = False
+
+if not is_inside_root:
print("")
sys.exit(0)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| file_path = os.path.realpath(sys.argv[1]) | |
| root_folder = os.path.realpath(sys.argv[2]) | |
| if not file_path.startswith(root_folder): | |
| print("") | |
| sys.exit(0) | |
| relative_path = file_path[len(root_folder):] | |
| file_path = os.path.realpath(sys.argv[1]) | |
| root_folder = os.path.realpath(sys.argv[2]) | |
| try: | |
| is_inside_root = os.path.commonpath((file_path, root_folder)) == root_folder | |
| except ValueError: | |
| is_inside_root = False | |
| if not is_inside_root: | |
| print("") | |
| sys.exit(0) | |
| relative_path = file_path[len(root_folder):] |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/dolphin/internxt-dolphin-actions.sh` around lines 14 - 21, Update the
root validation around file_path and root_folder to use os.path.commonpath and
confirm it exactly matches root_folder before deriving relative_path. Preserve
the existing empty-output and early-exit behavior for paths outside the root,
then slice only after this component-aware check.
| encoded="$(encode_relative_path "$file_path")" | ||
|
|
||
| if [ -z "$encoded" ]; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| local response | ||
| response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)" |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
URL-encode the Base64 path segment.
Line [58] inserts standard Base64 directly into /copy-link/:path. Standard Base64 can contain /, so valid paths can become multiple route segments and fail before req.params.path reaches src/apps/drive/hydration-api/controllers/contents.ts:145-159. Encode the complete segment before constructing the URL, or switch both sides to URL-safe Base64.
Proposed fix
local encoded
encoded="$(encode_relative_path "$file_path")"
+ local encoded_url
+ encoded_url="$(python3 - "$encoded" <<'PY'
+from urllib.parse import quote
+import sys
+
+print(quote(sys.argv[1], safe=""))
+PY
+)"
if [ -z "$encoded" ]; then
exit 0
fi
local response
- response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)"
+ response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded_url" 2>/dev/null || true)"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| encoded="$(encode_relative_path "$file_path")" | |
| if [ -z "$encoded" ]; then | |
| exit 0 | |
| fi | |
| local response | |
| response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)" | |
| encoded="$(encode_relative_path "$file_path")" | |
| local encoded_url | |
| encoded_url="$(python3 - "$encoded" <<'PY' | |
| from urllib.parse import quote | |
| import sys | |
| print(quote(sys.argv[1], safe="")) | |
| PY | |
| )" | |
| if [ -z "$encoded" ]; then | |
| exit 0 | |
| fi | |
| local response | |
| response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded_url" 2>/dev/null || true)" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/dolphin/internxt-dolphin-actions.sh` around lines 51 - 58, Update
encode_relative_path and the URL construction in the copy-link request so the
complete Base64 value is percent-encoded as a single path segment before
appending it to /copy-link/. Preserve the existing empty-value exit and ensure
the server receives the same decoded value through req.params.path.
| local response | ||
| response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)" | ||
| if [ -z "$response" ]; then |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Bound the local HTTP request.
Line [58] has no connection or total timeout. If the hydration service accepts the connection but stops responding, the Dolphin action can remain open indefinitely. Add bounded timeouts.
Proposed fix
- response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)"
+ response="$(curl -sS --connect-timeout 2 --max-time 10 \
+ -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| local response | |
| response="$(curl -sS -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)" | |
| if [ -z "$response" ]; then | |
| local response | |
| response="$(curl -sS --connect-timeout 2 --max-time 10 \ | |
| -X POST "$BASE_URL/copy-link/$encoded" 2>/dev/null || true)" | |
| if [ -z "$response" ]; then |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/dolphin/internxt-dolphin-actions.sh` around lines 57 - 59, Add bounded
connection and total timeouts to the curl invocation in the copy-link request
within the response hydration flow, ensuring stalled HTTP requests cannot block
the Dolphin action indefinitely while preserving the existing silent failure and
empty-response handling.
| ## Prerequisites for KDE based distros | ||
|
|
||
| ### KDE Wallet Configuration Guide | ||
|
|
||
| Our application requires the KDE key manager to be properly configured. Depending on your security needs, you can choose between two methods: | ||
|
|
||
| * **Method 1 (Recommended / Easy):** Uses standard symmetric encryption with a master password. It is fast, requires no additional software, and supports **automatic unlocking when you log in**. | ||
| * **Method 2 (Advanced / GPG):** Uses an OpenPGP key pair via Kleopatra for higher security, though it requires manual entry of your passphrase or PIN upon logging in. | ||
|
|
||
| > **Why Kleopatra?** It is the official KDE key manager, offering native integration with KDE Wallet, fewer permission conflicts, and a user-friendly setup wizard compared to generic GPG tools. | ||
| > | ||
| > For reference, Electron's secure storage API is documented here: [safe-storage](https://www.electronjs.org/docs/latest/api/safe-storage). | ||
|
|
||
| --- | ||
|
|
||
| ### Method 1: Standard Setup (Easy & Recommended) | ||
|
|
||
| This is the simplest way to set up KDE Wallet and allows seamless automatic unlocking upon system login. | ||
|
|
||
| #### Step 1: Open KDE Wallet Settings | ||
| 1. Open **System Settings**. | ||
| 2. Navigate to **KDE Wallet** (or search for *Wallet* in the search bar). | ||
| 3. Ensure **Enable the KDE wallet subsystem** is checked. | ||
|
|
||
| #### Step 2: Create a New Wallet | ||
| 1. Under **Automatic Wallet Selection**, click **Create New Wallet...** | ||
| 2. Enter a name for your wallet (e.g., `kdewallet`). | ||
| 3. Select **Blowfish encryption** (standard password) and click **Next**. | ||
| 4. Enter and confirm your **Master Password**. | ||
| > **Note:** If you set this password to match your Linux user login password, the wallet will unlock automatically when you sign in! | ||
| 5. Click **Finish**. | ||
|
|
||
| --- | ||
|
|
||
| ### Method 2: GPG Key Setup (Advanced) | ||
|
|
||
| Use this method if you prefer asymmetric GPG encryption managed via external key managers. | ||
|
|
||
| #### Step 1: Install Kleopatra | ||
| Install **Kleopatra**, which will be used to generate your GPG encryption key: | ||
|
|
||
| ```bash | ||
| sudo apt update && sudo apt install kleopatra | ||
| ``` | ||
|
|
||
| #### Step 2: Generate a GPG Key Pair | ||
| 1. Open **Kleopatra** and click **New Key Pair** (or **File > New Key Pair**). | ||
| 2. Select **Create a personal OpenPGP key pair**. | ||
| 3. Enter your **Name** and **Email Address**. | ||
| 4. Click **Create** (or **Finish**) to complete the setup. | ||
|
|
||
| ### Step 3: Configure KDE Wallet for GPG | ||
| 1. Open **System Settings** and search for **KDE Wallet**. | ||
| 2. Under **Automatic Wallet Selection**, click **Create New Wallet...** | ||
| 3. Select **Use GPG encryption for added security** and click **Next**. | ||
| 4. Choose the GPG key you created earlier in Kleopatra and click **Finish**. | ||
|
|
||
| --- | ||
|
|
||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix heading hierarchy in the new KDE Wallet section.
This section has two heading-level inconsistencies:
- "## Prerequisites for KDE based distros" (line 25) is an H2 inserted between "### .deb Package (Recommended)" and "### AppImage", both H3 subsections of "## Installation". This makes "### AppImage" render as nested under "## Prerequisites for KDE based distros" in a generated table of contents. Either demote this section to H3 (a sibling of ".deb Package" and "AppImage" under "## Installation"), or move it entirely outside the "## Installation" section.
- "### Step 3: Configure KDE Wallet for GPG" (line 76) uses H3, while its siblings "#### Step 1: Install Kleopatra" and "#### Step 2: Generate a GPG Key Pair" use H4. Align Step 3 to H4 for consistency.
Also, "KDE based distros" (line 25) should be hyphenated as "KDE-based distros".
🧰 Tools
🪛 LanguageTool
[grammar] ~25-~25: Use a hyphen to join words.
Context: ..._amd64.deb ``` ## Prerequisites for KDE based distros ### KDE Wallet Configurat...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` around lines 25 - 84, Fix the KDE Wallet section hierarchy in the
README: change “Prerequisites for KDE based distros” to an H3 sibling under
Installation, hyphenate it as “KDE-based distros,” and change “### Step 3:
Configure KDE Wallet for GPG” to H4 so it matches the other Method 2 step
headings.
Source: Linters/SAST tools
| function getExpectedPaths({ manager }: { manager: SupportedFileManager }) { | ||
| const home = homedir(); | ||
|
|
||
| if (manager === 'nautilus') { | ||
| return [join(home, '.local/share/nautilus-python/extensions/internxt-virtual-drive.py')]; | ||
| } | ||
|
|
||
| if (manager === 'nemo') { | ||
| return [join(home, '.local/share/nemo-python/extensions/internxt-virtual-drive.py')]; | ||
| } | ||
|
|
||
| return [ | ||
| join(home, '.local/share/kio/servicemenus/internxt-virtual-drive.desktop'), | ||
| join(home, '.local/share/kservices5/ServiceMenus/internxt-virtual-drive.desktop'), | ||
| join(home, '.local/share/internxt-dolphin-extension/internxt-dolphin-actions.sh'), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== files =="
git ls-files | rg '(^|/)file-manager-extension-smoke\.ts$|(^|/)file-manager-extension-service\.ts$|constants\.ts$|ser' | sed -n '1,120p'
echo
echo "== smoke outline =="
f="src/backend/features/file-manager-extension/file-manager-extension-smoke.ts"
if [ -f "$f" ]; then
wc -l "$f"
ast-grep outline "$f" --view compact || true
echo
sed -n '1,190p' "$f" | nl -ba
fi
echo
echo "== candidate service/constants =="
for f in src/backend/features/file-manager-extension/*.ts; do
echo "--- $f ($(wc -l < "$f")) ---"
rg -n "getFileManagerConfig|getFileManager|assets|destination|nautilus|nemo|dolphin|template|executable|SupportedFileManager" "$f" || true
doneRepository: internxt/drive-desktop-linux
Length of output: 9072
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== smoke.ts =="
python3 - <<'PY'
from pathlib import Path
p=Path('src/backend/features/file-manager-extension/file-manager-extension-smoke.ts')
text=p.read_text()
for i,line in enumerate(text.splitlines(),1):
print(f"{i:4}: {line}")
PY
echo
echo "== file-manager-extension files =="
for f in src/backend/features/file-manager-extension/*.ts; do
echo "--- $f ---"
wc -l "$f"
echo "-- symbols --"
ast-grep outline "$f" --view names || true
echo "-- relevant searches --"
rg -n "getFileManagerConfig|getFileManager|SupportedFileManager|assets|destination|template|executable|nautilus|nemo|internxt-dolphin|const|function " "$f" || true
doneRepository: internxt/drive-desktop-linux
Length of output: 23684
Derive expected paths from getFileManagerConfig.
getExpectedPaths duplicates asset destinations from service.ts. service.ts also owns template and executable flags, while this test hardcodes Dolphin only. Import getFileManagerConfig, await it in run(), and assert config.assets.map((asset) => asset.destination) plus the per-asset flags; update Dolphin template/executable checks where each asset sets them.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/backend/features/file-manager-extension/file-manager-extension-smoke.ts`
around lines 31 - 47, Replace the hardcoded path logic in getExpectedPaths with
values derived from getFileManagerConfig. In run(), await the configuration and
assert asset destinations from config.assets, including each asset’s template
and executable flags; update the Dolphin-specific checks to follow the flags on
the corresponding assets.
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| process.env.NODE_ENV = 'development'; | ||
| detectAvailableFileManagerMock.mockResolvedValue('nautilus'); | ||
| doesFileExistMock.mockResolvedValue(false); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Restore NODE_ENV after each test.
Line 35 changes a process-wide value. The suite never restores it. A later test in the same worker can inherit development and select different behavior.
Proposed fix
+const originalNodeEnv = process.env.NODE_ENV;
+
describe('service', () => {
@@
beforeEach(() => {
@@
doesFileExistMock.mockResolvedValue(false);
});
+
+ afterEach(() => {
+ if (originalNodeEnv === undefined) {
+ delete process.env.NODE_ENV;
+ } else {
+ process.env.NODE_ENV = originalNodeEnv;
+ }
+ });📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| beforeEach(() => { | |
| vi.clearAllMocks(); | |
| process.env.NODE_ENV = 'development'; | |
| detectAvailableFileManagerMock.mockResolvedValue('nautilus'); | |
| doesFileExistMock.mockResolvedValue(false); | |
| const originalNodeEnv = process.env.NODE_ENV; | |
| describe('service', () => { | |
| beforeEach(() => { | |
| vi.clearAllMocks(); | |
| process.env.NODE_ENV = 'development'; | |
| detectAvailableFileManagerMock.mockResolvedValue('nautilus'); | |
| doesFileExistMock.mockResolvedValue(false); | |
| }); | |
| afterEach(() => { | |
| if (originalNodeEnv === undefined) { | |
| delete process.env.NODE_ENV; | |
| } else { | |
| process.env.NODE_ENV = originalNodeEnv; | |
| } | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/backend/features/file-manager-extension/service.test.ts` around lines 33
- 37, Restore the process-wide NODE_ENV value after each test in the suite
containing the beforeEach setup. Capture the original value before overriding
it, then restore that value in an afterEach hook while keeping the existing mock
setup unchanged.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const destinationExists = await doesFileExist(destination); | ||
| if (destinationExists) { | ||
| if (asset.executable) { | ||
| await fs.chmod(destination, 0o755); |
| } | ||
|
|
||
| if (asset.executable) { | ||
| await fs.chmod(destination, 0o755); |
3 participants
What is Changed / Added
We've added unified file manager extension support for both Nautilus and Nemo. The app now automatically detects which manager you have installed and handles everything transparently. Created a new
file-manager-extensionmodule with detection logic, installation orchestration, and version tracking. Also fixed GTK compatibility issues (was 4.0, now 3.0) so Nemo works properly on Linux Mint. Updated IPC handlers, config store, and all components to use the new system. Includes 28 comprehensive tests covering both managers, and fixed a global mock issue that was breaking other tests.Why
Users on Linux Mint and other Cinnamon-based distros couldn't use the file manager integration since we only supported Nautilus. This unifies both managers under a single detection point, so the same extension system works whether you use Nautilus, Nemo, or switch between them. Makes the codebase cleaner too—one module handling both cases instead of duplicated logic everywhere.
Summary by CodeRabbit