Batch 2: retain hot-path benchmark evidence#18
Draft
imakris wants to merge 51 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Implements Batch 2 Checkpoint 2.1 on top of #17:
Exact candidate at
6e815ddDIAGNOSTIC_PASS, clean source6e815ddb1fa97e0c53a524c19f6e0ab28b454382, nonzero checksum, 863,348 nonuniform pixelsExact-head hosted validation is green in Linux 29115256431, FreeBSD 29115256325, macOS 29115256361, and Windows 29115256444: all eight jobs passed. All four retained text-enabled bundles independently recompute every declared hash, match candidate tree
c188d1ef, retain clean equal source/build/runtime identity, and finishDIAGNOSTIC_PASSwith native non-Null rendering, nonuniform pixels, nonzero checksums, and complete phase traces. All three xhigh reviewers returnedVERDICT: GREENon this exact candidate.Retained remediation history
86ad4c0: 5/8 green; Linux text-ON llvmpipe OOM and FreeBSD NFS ownership failure; all three xhigh reviewers RED.f07549b: FreeBSD rsync/copyback text-OFF passed and Linux softpipe removed the OOM, but softpipe 3.3 could not consume baked GLSL 410; the strict pixel oracle correctly rejected a clear-only frame.c5d6265: retained Qt-native selection; added compatible GLSL 330 + 410 artifacts and Core 3.3/single-sample only for the offscreen context. The measured target remains 4x and the pixel oracle remains strict.273e90e: calibration schema v3 explicitly names Core 3.3/1x context and 4x measured rendering, and rejects mismatched raw artifacts.a83316eleft FreeBSD driver selection native/default and disabled rendering workers, but run 29111950433 retainedstd::bad_allocat backend creation.836b178raised only guest capacity to 10 GiB, retained capacity/limits, and localized the repeated failure in run 29112893803 to Qt's convenience fallback-surface helper.989f5afsupplies the documented caller-owned QOffscreenSurface directly with the same 3.3/Core/1x request, avoiding only Qt's preliminary temporary context. Requested/resolved formats are retained and enforced; QRhi still creates the real native context and must render a nonuniform 4x frame.align_val_t{4}was passed directly to FreeBSDposix_memalign, which requires at least pointer-size alignment and returnedEINVAL, falsely surfaced asbad_alloc.6e815ddnormalizes only the effective platform alignment to at leastsizeof(void*), retains requested/effective telemetry, and adds a direct regression.The superseded 84-run artifacts are not accepted. Fresh 108-execution calibration follows green CI and unanimous iterative review. Its proposal must be inspected and approved by exact SHA-256 before checkpoint PASS can exist.
Three xhigh reviewers iterate until all three return green. Fable is not invoked or awaited per the owner's quota instruction. D4 remains open and is not claimed by this checkpoint.