Skip to content

[fix] some Server Component compatibility bugs#9

Merged
TechQuery merged 2 commits into
mainfrom
Server-Component-compatibility
Jun 15, 2026
Merged

[fix] some Server Component compatibility bugs#9
TechQuery merged 2 commits into
mainfrom
Server-Component-compatibility

Conversation

@TechQuery

@TechQuery TechQuery commented Jun 15, 2026

Copy link
Copy Markdown
Member

PR-9 PR-9 PR-9 Powered by Pull Request Badge

  1. [fix] some Server Component compatibility bugs
  2. [migrate] upgrade to Node.js 24, PNPM 11, Lint-Staged 17, Lucide-React 1 & other latest Upstream packages/actions

…t 1 & other latest Upstream packages/actions
Copilot AI review requested due to automatic review settings June 15, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses React/Next.js Server Component compatibility by avoiding creation of non-serializable event handler functions when optional callbacks aren’t provided, and modernizes the project toolchain/dependencies (Node/PNPM, Biome schema, GitHub Actions, and several libraries).

Changes:

  • Make DOM event handlers conditional on the presence of optional callback props in several registry UI blocks.
  • Introduce pnpm-workspace.yaml and update dependency/tooling versions (Biome schema, Node/PNPM, libraries).
  • Update CI workflow action versions and Node/PNPM versions.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
registry/new-york/blocks/pager/index.tsx Avoid creating onChange handlers when onChange prop is not provided (Server Component friendliness).
registry/new-york/blocks/editor/tools/color.tsx Make the <input type="color"> change handler conditional on onChange prop.
registry/new-york/blocks/badge-bar/index.tsx Gate click handlers behind optional callbacks for improved Server Component compatibility.
pnpm-workspace.yaml Add workspace-level PNPM configuration (packages/overrides/build allowlist).
package.json Upgrade deps/tooling; adjust scripts and remove inline PNPM config block.
biome.json Update Biome schema URL for the upgraded Biome version.
.github/workflows/main.yml Update CI/CD action versions and bump Node/PNPM versions used in workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread .github/workflows/main.yml
@TechQuery TechQuery force-pushed the Server-Component-compatibility branch from c8f2881 to e006633 Compare June 15, 2026 19:53
@TechQuery TechQuery force-pushed the Server-Component-compatibility branch from e006633 to e4171c2 Compare June 15, 2026 19:56
@TechQuery TechQuery added the enhancement Some improvements label Jun 15, 2026
@github-project-automation github-project-automation Bot moved this to In progress in 开源项目 Jun 15, 2026
@TechQuery TechQuery merged commit 26fa017 into main Jun 15, 2026
1 check passed
@TechQuery TechQuery deleted the Server-Component-compatibility branch June 15, 2026 20:02
@github-project-automation github-project-automation Bot moved this from In progress to Done in 开源项目 Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Some improvements

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants