[fix] some Server Component compatibility bugs#9
Merged
Conversation
…t 1 & other latest Upstream packages/actions
There was a problem hiding this comment.
Pull request overview
This PR addresses React/Next.js Server Component compatibility by avoiding creation of non-serializable event handler functions when optional callbacks aren’t provided, and modernizes the project toolchain/dependencies (Node/PNPM, Biome schema, GitHub Actions, and several libraries).
Changes:
- Make DOM event handlers conditional on the presence of optional callback props in several registry UI blocks.
- Introduce
pnpm-workspace.yamland update dependency/tooling versions (Biome schema, Node/PNPM, libraries). - Update CI workflow action versions and Node/PNPM versions.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
registry/new-york/blocks/pager/index.tsx |
Avoid creating onChange handlers when onChange prop is not provided (Server Component friendliness). |
registry/new-york/blocks/editor/tools/color.tsx |
Make the <input type="color"> change handler conditional on onChange prop. |
registry/new-york/blocks/badge-bar/index.tsx |
Gate click handlers behind optional callbacks for improved Server Component compatibility. |
pnpm-workspace.yaml |
Add workspace-level PNPM configuration (packages/overrides/build allowlist). |
package.json |
Upgrade deps/tooling; adjust scripts and remove inline PNPM config block. |
biome.json |
Update Biome schema URL for the upgraded Biome version. |
.github/workflows/main.yml |
Update CI/CD action versions and bump Node/PNPM versions used in workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c8f2881 to
e006633
Compare
e006633 to
e4171c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.