Skip to content

Complete Notifications correctness and Slack parity #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binaryfire merged 19 commits into from
Aug 5, 2026
Merged

Complete Notifications correctness and Slack parity #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2fccc04
Add storage attachments to notification mail messages
binaryfire Aug 5, 2026
0aa02a3
Bound generated Slack action IDs
binaryfire Aug 5, 2026
1141851
Add Slack Block Kit select elements
binaryfire Aug 5, 2026
27686f9
Preserve valid UTF-8 in Slack text
binaryfire Aug 5, 2026
69b6999
Restore Slack test mapping and expose Builder URLs
binaryfire Aug 5, 2026
d36a2fe
Support modern Slack messages across delivery routes
binaryfire Aug 5, 2026
01821a2
Make notification failure ownership reentrant
binaryfire Aug 5, 2026
6041749
Prove notification manager coroutine isolation
binaryfire Aug 5, 2026
15fc20c
Align notification queue precedence and metadata
binaryfire Aug 5, 2026
3350eb0
Complete database notification types and scopes
binaryfire Aug 5, 2026
b73dab4
Give anonymous notifiables an explicit null identity
binaryfire Aug 5, 2026
1acbf6a
Run notification tests on the framework harness
binaryfire Aug 5, 2026
4329b5f
Isolate translation integration test state
binaryfire Aug 5, 2026
89dc4e9
Document current notification capabilities and provenance
binaryfire Aug 5, 2026
a0696c9
Track Eloquent PHPStan forwarding support
binaryfire Aug 5, 2026
13ec1d5
Add the Notifications implementation plan
binaryfire Aug 5, 2026
6ca54fa
Complete the Notifications audit records
binaryfire Aug 5, 2026
56cde36
Merge branch '0.4' into audit/notifications-correctness-parity
binaryfire Aug 5, 2026
cdb61df
Harden Slack Block Kit protocol boundaries
binaryfire Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions docs/plans/2026-07-12-0900-framework-coroutine-state-lifecycle-audit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,8 @@ Add one row only for a shared finding or changed lower-level assumption that ano
| `queue-11` | `queue` | `events`, `queue`, and `broadcasting` (revalidation complete) | `Correct event dispatch, queued-consumer isolation, and queue interoperability`; finding `queue-11` |
| `queue-12` | `bus`, `queue` | `events`, `bus`, `queue`, and `broadcasting` (revalidation complete) | `Correct event dispatch, queued-consumer isolation, and queue interoperability`; finding `queue-12` |
| `foundation-01` | `foundation` | `support` and `foundation` (revalidation complete) | `Correct event dispatch, queued-consumer isolation, and queue interoperability`; finding `foundation-01` |
| `support-02` | `support` | `auth`, `broadcasting` (revalidation complete), `bus` (revalidation complete), `cache` (revalidation complete), `concurrency`, `console` (revalidation complete), `container`, `contracts`, `cookie`, `database` (revalidation complete), `events`, `filesystem` (revalidation complete), `foundation` (revalidation complete), `hashing` (revalidation complete), `horizon` (revalidation complete), `inertia`, `jwt`, `log`, `mail`, `notifications`, `permission`, `pipeline`, `queue` (revalidation complete), `redis` (revalidation complete), `reverb` (revalidation complete), `routing`, `sanctum`, `scout`, `session` (revalidation complete), `socialite`, `telescope`, `testbench`, `translation`; later full consumer audits | `Normalize framework enum identifiers at string boundaries`; finding `support-02`; sibling findings `translation-01` and `reverb-03`; linked detail plan `2026-07-15-0920-framework-enum-identifier-contracts.md` |
| `support-02` | `support` | `auth`, `broadcasting` (revalidation complete), `bus` (revalidation complete), `cache` (revalidation complete), `concurrency`, `console` (revalidation complete), `container`, `contracts`, `cookie`, `database` (revalidation complete), `events`, `filesystem` (revalidation complete), `foundation` (revalidation complete), `hashing` (revalidation complete), `horizon` (revalidation complete), `inertia`, `jwt`, `log`, `mail`, `notifications` (revalidation complete), `permission`, `pipeline`, `queue` (revalidation complete), `redis` (revalidation complete), `reverb` (revalidation complete), `routing`, `sanctum`, `scout`, `session` (revalidation complete), `socialite`, `telescope`, `testbench`, `translation`; later full consumer audits | `Normalize framework enum identifiers at string boundaries`; finding `support-02`; sibling findings `translation-01` and `reverb-03`; linked detail plan `2026-07-15-0920-framework-enum-identifier-contracts.md` |
| `macroable-03` | `macroable` | `cookie`, `log`, and `notifications` (revalidation complete); later full `jwt` audit | `Complete Macroable callable and test-state handling`; finding `macroable-03` |
| `auth-01` | `support`, `auth` | later full `auth` audit | `Correct Support utility boundaries and authentication timing isolation`; finding `auth-01` |
| `encryption-03` | `encryption` | `contracts`, `support`, `filesystem`, and `foundation` (revalidation complete) | `Harden encryption rotation, key publication, and global lifecycle state`; finding `encryption-03` |
| `sanctum-01` | `sanctum` | `encryption`; later full `sanctum` audit | `Harden encryption rotation, key publication, and global lifecycle state`; finding `sanctum-01` |
Expand Down Expand Up @@ -1112,7 +1113,8 @@ Add one row only for a shared finding or changed lower-level assumption that ano
| `filesystem-12` | `filesystem` | `session` (revalidation complete) | `Complete Session lifecycles, persistence, and current Laravel parity`; finding `filesystem-12` |
| `session-23` | `cache` | `session` (revalidation complete) | `Complete Session lifecycles, persistence, and current Laravel parity`; finding `session-23` |
| `contracts-09` | `contracts` | `foundation` and `broadcasting` (revalidation complete) | `Complete Queue pooling, payload durability, and current Laravel parity`; finding `contracts-09` |
| `notifications-07` | `contracts` | later full `notifications` audit | `Complete Queue pooling, payload durability, and current Laravel parity`; finding `notifications-07` |
| `notifications-07` | `contracts` | `notifications` (revalidation complete) | `Harden framework contracts and request-scoped state`; finding `notifications-07` |
| `notifications-12` | `notifications` | `horizon` and `notifications` (revalidation complete) | `Complete Notifications correctness, Slack parity, and reentrant failure ownership`; finding `notifications-12` |
| `queue-22` | `queue` | `horizon` (revalidation complete); later full `telescope` audit | `Complete Queue pooling, payload durability, and current Laravel parity`; finding `queue-22` |
| `queue-29` | `queue` | `foundation` (revalidation complete) | `Complete Queue pooling, payload durability, and current Laravel parity`; finding `queue-29` |
| `queue-36` | `queue`, `support` | `support` (revalidation complete) | `Complete Queue pooling, payload durability, and current Laravel parity`; finding `queue-36` |
Expand Down Expand Up @@ -1146,10 +1148,10 @@ Add one row only for a shared finding or changed lower-level assumption that ano
| `fortify-02` | `fortify` | `fortify` (targeted correction complete); later full `fortify` audit | `Harden Eloquent identity and partial-projection safety`; finding `fortify-02` |
| `pagination-01` | `pagination` | `pagination` (targeted correction complete); later full `pagination` audit | `Harden Eloquent identity and partial-projection safety`; finding `pagination-01` |
| `pagination-02` | `pagination` | `pagination` (targeted correction complete); later full `pagination` audit | `Harden Eloquent identity and partial-projection safety`; finding `pagination-02` |
| `queue-41` | `database`, `queue` | `database`, `queue`, and `notifications` (targeted correction complete); later full `notifications` audit | `Harden Eloquent identity and partial-projection safety`; finding `queue-41` |
| `queue-41` | `database`, `queue` | `database`, `queue`, and `notifications` (revalidation complete) | `Harden Eloquent identity and partial-projection safety`; finding `queue-41` |
| `scout-01` | `scout` | `scout` (targeted correction complete); later full `scout` audit | `Harden Eloquent identity and partial-projection safety`; finding `scout-01` |
| `scout-02` | `scout` | `scout` (targeted correction complete); later full `scout` audit | `Harden Eloquent identity and partial-projection safety`; finding `scout-02` |
| `notifications-08` | `notifications` | `notifications` (targeted correction complete); later full `notifications` audit | `Harden Eloquent identity and partial-projection safety`; finding `notifications-08` |
| `notifications-08` | `notifications` | `notifications` (revalidation complete) | `Harden Eloquent identity and partial-projection safety`; finding `notifications-08` |
| `http-04` | `http` | `http` (revalidation complete) | `Harden Eloquent identity and partial-projection safety`; finding `http-04` |
| `http-05` | `http` | `http` (revalidation complete) | `Harden Eloquent identity and partial-projection safety`; finding `http-05` |
| `http-06` | `http` | `http` (revalidation complete) | `Harden Eloquent identity and partial-projection safety`; finding `http-06` |
Expand Down Expand Up @@ -1246,7 +1248,7 @@ The order is lower-level first where practical. Hypervel has cross-cutting depen
- [x] `grpc`
- [x] `broadcasting`
- [x] `mail`
- [ ] `notifications`
- [x] `notifications`

### Application and domain packages

Expand Down
Loading