Operator fault panel: Thai translation with EN/ไทย toggle#25
Merged
Conversation
Adds an optional Thai variant of each fault's text to the red operator fault panel, so Calcomp operators can read remediation steps in Thai. - OutcomeDetails gains an optional description_th field. It rides to the browser via the existing as_base_types()/websocket path and is meant for the GUI only — the framework strips it from the JSON report before shipping, so downstream consumers (Manufacturing Service, Calcomp, Athena) are unchanged. - The panel header gets a global EN/ไทย toggle, persisted per browser in localStorage (htf-fault-panel-language). Static panel labels are hardcoded bilingual; per-fault title/steps come from the catalogue's titleThai/stepsThai and fall back to English per part when missing. - station-data parses description_th with the same literal 'What to do:' machine marker as the English text. - test-summary.component.ts previously contained a stray NUL byte that made git treat it as binary; this commit removes it. - dist/ rebuilt (bundle e5169df5).
Coverage Report for CI Build 28837558050Coverage increased (+0.005%) to 60.612%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Thai to the red operator fault panel so Calcomp operators can read remediation steps without outside help.
OutcomeDetails.description_th(optional, defaultNone) — the Thai variant of a fault's panel text. It reaches the browser through the existingas_base_types()/websocket path automatically. It is GUI-only: the framework strips it from the JSON report before shipping (see companion hardware-test-framework PR), so Manufacturing Service / Calcomp / Athena payloads are byte-identical to today.htf-fault-panel-language). Default English.PANEL_LABELS).titleThai/stepsThai, authored in Farmhand). Each part falls back to English independently when no Thai exists, so untranslated entries render exactly as before.station-data.tssplitsdescription_thon the same literalWhat to do:machine marker as the English text (Farmhand normalises Thai marker variants back to the English marker on save).test-summary.component.tscontained a stray NUL byte that made git treat it as binary; removed.Backwards compatibility
add_outcome_details()keeps its old 2-arg signature;description_this optional.description_th, English panel).master(Consolidate Deployed Changes with Master + labelling change #24): coexists with the multislot history label —dist/rebuilt from current master + this change (bundlee5169df5).Testing
stepsThairender fully in Thai, untranslated entries fall back to English.Companion PRs
description_thfrom the catalogue cache + strips it from the JSON report.titleThai/stepsThai: hardware-test-service#204, client v1.0.44, Farmhand #3697 (all merged).