Conditional boot animation implementation#6
Open
kurtbahartr wants to merge 3 commits into
Open
Conversation
These exact places makes sure the props are updated even when we have auto/custom theme applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of commits implements the base line for conditional boot animation depending on system theme. If the system theme is light, it will show what's in bootanimation.zip. If the system theme is dark, it will show what's in bootanimation-dark.zip.
Previously, this condition was whether
ro.boot.themewas1. It's meant to be set by specific bootloaders, but no bootloader sets this prop from what I can see.Also wait until persistent props are loaded before showing boot animation so that we don't leave a race condition where sometimes dark boot animation would be shown even when system theme was light. This slightly increases the amount of time bootloader splash is shown, but better safe than sorry.
Should be coupled with halcyonproject/system_sepolicy#1.