Remove newsletter signup card AB test#16229
Open
georgerichmond wants to merge 1 commit into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
newsletters-signup-card-country-illustrationA/B test entry fromabTests.ts, freeing up space BgetVariantName()from'control'to'variantIllustratedCard', so all eligible web users now receive the illustrated card regardless of AB participationvariantNewFieldtest cases and updates assertions to expectnewsletter-signup-card-containerfor all web users with the flag onThe AB framework itself (
useAB,abResolvedgating, the placeholder while hydrating) is left untouched, ready for a future test.Why?
The
variantIllustratedCarddesign has been validated has been set 100% of users. We need to free up the ab test slot for the Feast team. Rather than a large cleanup PR, this is the smallest safe step: delete the test and hardcode the winning variant as the default. A follow-up PR can remove the now-redundant AB resolution logic and dead code.Screenshots
No visual change — users who were already in the
variantIllustratedCardgroup see no difference, and users previously incontrolwill now see the illustrated card for the first time.