Skip to content

Remove newsletter signup card AB test#16229

Open
georgerichmond wants to merge 1 commit into
mainfrom
remove-newsletter-signup-ab-test
Open

Remove newsletter signup card AB test#16229
georgerichmond wants to merge 1 commit into
mainfrom
remove-newsletter-signup-ab-test

Conversation

@georgerichmond

@georgerichmond georgerichmond commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What does this change?

  • Deletes the newsletters-signup-card-country-illustration A/B test entry from abTests.ts, freeing up space B
  • Changes the fallback in getVariantName() from 'control' to 'variantIllustratedCard', so all eligible web users now receive the illustrated card regardless of AB participation
  • Updates the test suite to reflect the new behaviour — removes the dead variantNewField test cases and updates assertions to expect newsletter-signup-card-container for all web users with the flag on

The AB framework itself (useAB, abResolved gating, the placeholder while hydrating) is left untouched, ready for a future test.

Why?

The variantIllustratedCard design has been validated has been set 100% of users. We need to free up the ab test slot for the Feast team. Rather than a large cleanup PR, this is the smallest safe step: delete the test and hardcode the winning variant as the default. A follow-up PR can remove the now-redundant AB resolution logic and dead code.

Screenshots

No visual change — users who were already in the variantIllustratedCard group see no difference, and users previously in control will now see the illustrated card for the first time.

Before After
before after

@georgerichmond georgerichmond requested a review from a team as a code owner June 19, 2026 16:38
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@georgerichmond georgerichmond added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jun 19, 2026
@georgerichmond georgerichmond self-assigned this Jun 19, 2026
@georgerichmond georgerichmond added the run_chromatic Runs chromatic when label is applied label Jun 19, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant