Rename feast-recipe-nudge A/B test to v2 and add control group#16228
Open
andresilva-guardian wants to merge 9 commits into
Open
Rename feast-recipe-nudge A/B test to v2 and add control group#16228andresilva-guardian wants to merge 9 commits into
andresilva-guardian wants to merge 9 commits into
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
…an/dotcom-rendering into afs/feast-recipe-nudge-v2
There was a problem hiding this comment.
Pull request overview
Updates the Feast contextual nudge experiment configuration by versioning the A/B test name and introducing an explicit control group, with corresponding client-side gating updated to the new test ID.
Changes:
- Renamed the A/B test from
feast-recipe-nudgetofeast-recipe-nudge-v2. - Added an explicit
controlgroup alongsidevariant-1in the test config. - Updated
FeastContextualNudgeto reference the new test name when deciding whether to render.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dotcom-rendering/src/components/FeastContextualNudge.island.tsx |
Switches the runtime gating to use the new A/B test name (feast-recipe-nudge-v2). |
ab-testing/config/abTests.ts |
Renames the test and adds a control group to the configured group list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
194
to
+197
| type: "client", | ||
| audienceSize: 50 / 100, | ||
| audienceSpace: "A", | ||
| groups: ["variant-1"], | ||
| groups: ["control", "variant-1"], |
cemms1
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Renames the
feast-recipe-nudgeA/B test tofeast-recipe-nudge-v2and updates its configuration:controlgroup alongsidevariant-1Bwith 100% audience size (50% control / 50% variant-1)console.logso it only fires forvariant-1usersControlStorybook story to document the hidden-nudge stateWhy?
The original test had no control group, meaning users not seeing the nudge weren't tracked as part of the experiment. Versioning to
v2reflects this config change. SpaceBis used to avoid conflicts with other live tests on spaceA, and the 100% audience size ensures enough data is collected across both groups.Screenshots
No visual changes — this is a configuration and logic update only.