Skip to content

Rename feast-recipe-nudge A/B test to v2 and add control group#16228

Open
andresilva-guardian wants to merge 9 commits into
mainfrom
afs/feast-recipe-nudge-v2
Open

Rename feast-recipe-nudge A/B test to v2 and add control group#16228
andresilva-guardian wants to merge 9 commits into
mainfrom
afs/feast-recipe-nudge-v2

Conversation

@andresilva-guardian

@andresilva-guardian andresilva-guardian commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Renames the feast-recipe-nudge A/B test to feast-recipe-nudge-v2 and updates its configuration:

  • Adds an explicit control group alongside variant-1
  • Moves the test to audience space B with 100% audience size (50% control / 50% variant-1)
  • Gates the dev console.log so it only fires for variant-1 users
  • Adds a Control Storybook story to document the hidden-nudge state

Why?

The original test had no control group, meaning users not seeing the nudge weren't tracked as part of the experiment. Versioning to v2 reflects this config change. Space B is used to avoid conflicts with other live tests on space A, and the 100% audience size ensures enough data is collected across both groups.

Screenshots

No visual changes — this is a configuration and logic update only.

@andresilva-guardian andresilva-guardian requested a review from a team as a code owner June 19, 2026 14:09
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

@andresilva-guardian andresilva-guardian added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jun 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Feast contextual nudge experiment configuration by versioning the A/B test name and introducing an explicit control group, with corresponding client-side gating updated to the new test ID.

Changes:

  • Renamed the A/B test from feast-recipe-nudge to feast-recipe-nudge-v2.
  • Added an explicit control group alongside variant-1 in the test config.
  • Updated FeastContextualNudge to reference the new test name when deciding whether to render.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
dotcom-rendering/src/components/FeastContextualNudge.island.tsx Switches the runtime gating to use the new A/B test name (feast-recipe-nudge-v2).
ab-testing/config/abTests.ts Renames the test and adds a control group to the configured group list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 194 to +197
type: "client",
audienceSize: 50 / 100,
audienceSpace: "A",
groups: ["variant-1"],
groups: ["control", "variant-1"],

@DanielOkoronkwo-GDN DanielOkoronkwo-GDN left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andresilva-guardian andresilva-guardian added the run_chromatic Runs chromatic when label is applied label Jun 19, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants