Wire scorecard into live layout#16216
Draft
Jakeii wants to merge 4 commits into
Draft
Conversation
github-actions
Bot
removed
the
run_chromatic
Jakeii
force-pushed
the
jlk/wire-cricket-scorecard-tab
branch
from
e05ae5f to
ac0fb1e
Compare
github-actions
Bot
removed
the
run_chromatic
Jakeii
commented
Jun 19, 2026
| config: { isPaidContent, host, hasLiveBlogTopAd, hasSurveyAd }, | ||
| } = article; | ||
|
|
||
| const ab = useAB(); |
Member
Author
There was a problem hiding this comment.
Suggest using "Hide Whitespace" to review this file!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Wrap the elements we want to replace with the scorecard when the tab is clicked with an element in the LiveLayout.
I've also removed the
initalDataprop from the cricket match header components and updated storybook to mock the data fetching instead, as we will never haveinitalDatafor the cricket match header. (It's only available on the scorecard page, which we're replacing with a client side rendered tab)Why?
Get the scorecard working behind the 0% test!