xds: fix TSAN data races in xDS security components and tests#12829
Merged
kannanjgithub merged 1 commit intoMay 27, 2026
Conversation
This change resolves several data races reported by ThreadSanitizer (TSAN) in XdsSecurityClientServerTest and associated xDS security components. Key changes: - Made certificate, key storage, and SSL context fields volatile in CertProviderSslContextProvider and DynamicSslContextProvider to ensure safe publication between Netty EventLoop threads and background FileWatcher threads. - Made experimental static flags (enableSpiffe and useChannelAuthorityIfNoSniApplicable) volatile. These flags are toggled by tests while being read by background networking threads; making them volatile ensures these transitions are thread-safe and TSAN-compliant.
kannanjgithub
force-pushed
the
tsan-race-cert-provider-fix
branch
2 times, most recently
from
be5e50c to
d629d99
Compare
shivaspeaks
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves several data races reported by ThreadSanitizer (TSAN) in XdsSecurityClientServerTest and associated xDS security components.
Key changes:
b/514777926