bazel build support for Android (bzlmod mode only)#12811
Conversation
jdcormie
force-pushed
the
bazel-binder-3
branch
2 times, most recently
from
63f127a to
856afb3
Compare
jdcormie
force-pushed
the
bazel-binder-3
branch
12 times, most recently
from
6984b53 to
58f7062
Compare
jdcormie
changed the title
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Not having WORKSPACE support for android seems fine.
What's your goal here? If we just want the building for ourselves, then we could visibility-restrict the new targets and we wouldn't need to figure out how to handle the android maven repository.
It would be nice to let users depend on //android and //binder but my goal right now is to get errorprone working in github and port over certain google3 tests that are much easier to express using bazel. So restricted visibility SGTM. |
jdcormie
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
| ] | ||
| # GRPC_DEPS_END | ||
|
|
||
| ANDROID_ARTIFACTS = [ |
There was a problem hiding this comment.
Let's inline this below. IO_GRPC_GRPC_JAVA_ARTIFACTS is split out so so the CI can verify it is identical in the WORKSPACE. Which doesn't apply here.
Makes //android and //binder available to external consumers of grpc-java via bazel/bzlmod/BCR.
errorprone checks on android code are now actually enforced, at the cost of longer kokoro/android.sh runtime.
WORKSPACE support is also possible but it ended up looking too hairy for me to put my name on.