Skip to content

fix(eval): preserve custom eval metadata#5922

Open
he-yufeng wants to merge 1 commit into
google:mainfrom
he-yufeng:fix/eval-extra-metadata-fresh
Open

fix(eval): preserve custom eval metadata#5922
he-yufeng wants to merge 1 commit into
google:mainfrom
he-yufeng:fix/eval-extra-metadata-fresh

Conversation

@he-yufeng
Copy link
Copy Markdown
Contributor

Summary

  • allow evaluation models to preserve caller-provided metadata fields
  • add a regression test covering extra fields on SessionInput and EvalCase

Fixes #5906

To verify

  • PYTHONPATH=src python -m pytest tests/unittests/evaluation/test_eval_case.py -q
  • python -m pyink --check src/google/adk/evaluation/common.py tests/unittests/evaluation/test_eval_case.py
  • python -m ruff check src/google/adk/evaluation/common.py tests/unittests/evaluation/test_eval_case.py
  • git diff --check

@adk-bot adk-bot added the eval [Component] This issue is related to evaluation label May 31, 2026
@rohityan rohityan self-assigned this Jun 1, 2026
@he-yufeng he-yufeng force-pushed the fix/eval-extra-metadata-fresh branch from 9f20bb8 to 9516053 Compare June 2, 2026 06:24
@he-yufeng he-yufeng force-pushed the fix/eval-extra-metadata-fresh branch from 9516053 to 1d17dd7 Compare June 2, 2026 19:14
@he-yufeng
Copy link
Copy Markdown
Contributor Author

Rebased this branch onto the latest main.

Validation on the rebased branch:

  • PYTHONPATH=src .venv\Scripts\python.exe -m pytest tests\unittests\evaluation\test_eval_case.py -q
  • PYTHONPATH=src .venv\Scripts\python.exe -m py_compile src\google\adk\evaluation\common.py tests\unittests\evaluation\test_eval_case.py
  • git diff --check upstream/main...HEAD

Note: using the repo-local .venv is necessary on my Windows machine; the global conda environment has an older/incompatible google-genai install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval [Component] This issue is related to evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EvalBaseModel extra='forbid' rejects custom fields in session_input and eval cases

3 participants