fix: allow builder assistant special app name#5918
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for submitting this pull request! This PR is a bug fix and addresses issue #5877. While you have provided a detailed "To verify" section with the commands, could you please provide:
Providing this verification evidence helps our maintainers review and merge your PR more efficiently. For more details, you can refer to the Contribution Guidelines. Thank you! |
61baef5 to
50f2c0d
Compare
Contributor
Author
|
Rebased onto current upstream/main and refreshed the PR verification evidence. The targeted pytest commands now report 2 passed and 1 passed respectively; pyink and diff-check also pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adk webrunner construction for internal special agents such as__adk_agent_builder_assistantFixes #5877.
To verify
C:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pytest tests\unittests\cli\test_fast_api.py -q -k "special_agent_name or bigquery"— 2 passed, 73 deselected, 8 warningsC:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pytest tests\unittests\apps\test_apps.py -q -k "app_name_must_be_valid or path_like"— 1 passed, 15 deselected, 4 warningsC:\dev\GITHUB-clean\adk-python\.venv\Scripts\python.exe -m pyink --check src\google\adk\cli\api_server.py tests\unittests\cli\test_fast_api.py— passed, 2 files left unchangedgit diff --check -- src\google\adk\cli\api_server.py tests\unittests\cli\test_fast_api.py— passed