feat(gooddata-sdk): [AUTO] Remove LLM endpoint entities and schemas from metadata API#1627
Open
yenkins-admin wants to merge 3 commits into
Open
feat(gooddata-sdk): [AUTO] Remove LLM endpoint entities and schemas from metadata API#1627yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
+ Coverage 79.03% 79.09% +0.05%
==========================================
Files 231 231
Lines 15634 15634
==========================================
+ Hits 12357 12366 +9
+ Misses 3277 3268 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The implement agent collaterally modified three files unrelated to C004's LLM-endpoint removal while chasing pre-existing ty check errors: - pyproject.toml (widened ty allowed-unresolved-imports) - compute/model/execution.py (stripped # type: ignore) - compute/model/filter.py (added redundant type annotations) Reverting them to master restores the types-check green path. The LLM-removal deliverables (catalog/organization fixtures + test) are unchanged. Pipeline guard added in gdc-nas (SHARED_CORE_BLOCKED_FOR_WRITE in sdk_sync/hooks.py) so future implement runs cannot reproduce this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added integration test for
list_llm_providers(the replacement for the permanently-removedllmEndpointsAPI). No SDK wrapper code changes needed: the SDK already usesCatalogLlmProvider(not the removed endpoint model), andACTIVE_LLM_ENDPOINTremoval fromallowed_valueswill be handled by the next api-client regeneration.Impact: modification | Services:
metadata-apiSource commits (gdc-nas):
628c04cby Jan Kadlec — Merge pull request #23083 from hkad98/jkd/llm-entity-removal-4Files changed
packages/gooddata-sdk/tests/catalog/test_catalog_organization.pypackages/gooddata-sdk/tests/catalog/fixtures/organization/list_llm_providers.yamlAgent decisions
Decisions (2)
No SDK wrapper code changes for ACTIVE_LLM_ENDPOINT removal — Rely on api-client regeneration to remove ACTIVE_LLM_ENDPOINT from allowed_values
Integration test for list_llm_providers instead of llmEndpoints — Test list_llm_providers since llmEndpoints now returns 410 Gone
Assumptions to verify (2)
Risks (1)
Layers touched (1)
packages/gooddata-sdk/tests/catalog/test_catalog_organization.pypackages/gooddata-sdk/tests/catalog/fixtures/organization/list_llm_providers.yamlOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow