Skip to content

test: fix vacuous assertions in src/execute.rs #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −9
Draft

test: fix vacuous assertions in src/execute.rs #1673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions src/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,7 +1012,12 @@ mod tests {
let ctx = ExecutionContext::default();

let result = execute_safe_output(&entry, &ctx).await;
assert!(result.is_err());
let msg = result.unwrap_err().to_string();
assert!(
msg.contains("Failed to parse create-work-item"),
"got: {msg}"
);
assert!(msg.contains("missing field"), "got: {msg}");
}

#[tokio::test]
Expand All @@ -1031,8 +1036,12 @@ mod tests {
let entry = serde_json::json!({"name": "update-wiki-page"});
let ctx = ExecutionContext::default();

let result = execute_safe_output(&entry, &ctx).await;
assert!(result.is_err());
let msg = execute_safe_output(&entry, &ctx).await.unwrap_err().to_string();
assert!(
msg.contains("Failed to parse update-wiki-page"),
"got: {msg}"
);
assert!(msg.contains("missing field"), "got: {msg}");
}

#[tokio::test]
Expand Down Expand Up @@ -1077,8 +1086,12 @@ mod tests {
let entry = serde_json::json!({"name": "create-wiki-page"});
let ctx = ExecutionContext::default();

let result = execute_safe_output(&entry, &ctx).await;
assert!(result.is_err());
let msg = execute_safe_output(&entry, &ctx).await.unwrap_err().to_string();
assert!(
msg.contains("Failed to parse create-wiki-page"),
"got: {msg}"
);
assert!(msg.contains("missing field"), "got: {msg}");
}

#[tokio::test]
Expand All @@ -1087,8 +1100,12 @@ mod tests {
let entry = serde_json::json!({"name": "upload-pipeline-artifact"});
let ctx = ExecutionContext::default();

let result = execute_safe_output(&entry, &ctx).await;
assert!(result.is_err());
let msg = execute_safe_output(&entry, &ctx).await.unwrap_err().to_string();
assert!(
msg.contains("Failed to parse upload-pipeline-artifact"),
"got: {msg}"
);
assert!(msg.contains("missing field"), "got: {msg}");
}

#[tokio::test]
Expand Down Expand Up @@ -1133,8 +1150,12 @@ mod tests {
let entry = serde_json::json!({"name": "comment-on-work-item"});
let ctx = ExecutionContext::default();

let result = execute_safe_output(&entry, &ctx).await;
assert!(result.is_err());
let msg = execute_safe_output(&entry, &ctx).await.unwrap_err().to_string();
assert!(
msg.contains("Failed to parse comment-on-work-item"),
"got: {msg}"
);
assert!(msg.contains("missing field"), "got: {msg}");
}

#[tokio::test]
Expand Down