Make fields parameter available by default - #2952
Merged
Merged
Conversation
Keep fields_param as an independently controlled feature flag while removing it from the Insiders expansion. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes fields_param from Insiders defaults while preserving explicit feature-flag activation.
Changes:
- Removes automatic Insiders enablement.
- Updates resolution coverage.
- Regenerates Insiders documentation.
Show a summary per file
| File | Description |
|---|---|
pkg/github/feature_flags.go |
Removes the flag from Insiders expansion. |
pkg/github/feature_flags_test.go |
Verifies Insiders no longer enables it. |
docs/insiders-features.md |
Removes its generated Insiders schema documentation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Medium
RossTarrant
previously approved these changes
Jul 29, 2026
Remove the fields_param feature flag and legacy tool variants so selected read tools always advertise and honor fields. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5c43cc70-27b5-47b4-bbd1-99d20f42d61b
tommaso-moro
changed the title
RossTarrant
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fieldsparameter available by default on selected read toolsfields_paramfeature flag and legacy no-fields tool variantsFollow-up to #2775, #2810, and #2890.
Validation
UPDATE_TOOLSNAPS=true go test ./...script/lintscript/testscript/generate-docs