Fix Cargo.lock and add check to ensure the working tree remains clean after build#1600
Fix Cargo.lock and add check to ensure the working tree remains clean after build#1600qmonnet wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA ChangesCI Dirty-Tree Verification
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Without the Cargo.lock fix, this fails as expected 🎉 |
The PR adding the crate was created before the latest version bump. Fixes: fe0ec69 ("feat(acl): crate scaffolding + software reference backend") Signed-off-by: Quentin Monnet <qmo@qmon.net>
Avoid missing things such as Cargo.lock updates for new crates when a PR has been created before a version bump (which we should catch at least in the merge queue with the proposed step), or any other file generated in-tree during the build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
8a16b66 to
8e96921
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Rust lockfile for the recent dataplane-acl workspace version bump and adds a CI safeguard to detect when build/test steps leave tracked files modified (e.g., an uncommitted Cargo.lock update).
Changes:
- Bump
dataplane-acl’s recorded version inCargo.lockto0.22.0. - Add a
verify-clean-treestep (via YAML anchor) to fail the workflow ifgit statusis dirty after running build-related steps.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.lock | Updates the dataplane-acl package version to match the workspace version bump. |
| .github/workflows/dev.yml | Adds a post-build git status cleanliness check and reuses it across jobs via an anchor. |
|
And it passes with the Cargo.lock fix. Seems all good. |
Update Cargo.lock to account for the project version change for the latest crate,
dataplane-acl.To avoid missing things in the future such as Cargo.lock updates for new crates when a PR has been created before a version bump (which we should catch at least in the merge queue with the proposed step), or any other file generated in-tree during the build, add a dedicated step to the dev.yml workflow.