Skip to content

chore: unity cli testing setup - #2780

Merged
bitsandfoxes merged 5 commits into
mainfrom
chore/agent-test-harness
Jul 28, 2026
Merged

chore: unity cli testing setup#2780
bitsandfoxes merged 5 commits into
mainfrom
chore/agent-test-harness

Conversation

@bitsandfoxes

@bitsandfoxes bitsandfoxes commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This enables and utilizes the new Unity CLI to run the unit tests. Updated the existing script to do basic error handling and logging along with parsing the results.

#skip-changelog

Comment thread scripts/run-tests.ps1 Outdated
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1 Outdated
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/run-tests.ps1
Comment thread scripts/download-sentry-cli.ps1

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c765751. Configure here.

$baseUrl = "$($conf.repo)/releases/download/$($conf.version)/sentry-cli-"
$targetFiles = $platforms | ForEach-Object {
$name = if ($_.StartsWith('Windows')) { "$_.exe" } else { $_ }
Join-Path $targetDir "sentry-cli-$name"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows CLI skip check broken

Medium Severity

The Windows sentry-cli cache check builds expected filenames with "$_.exe", which PowerShell reads as a property on $_, not the platform name plus .exe. The path never matches sentry-cli-Windows-x86_64.exe, so the script treats a complete download as incomplete and re-downloads on every run on Windows.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c765751. Configure here.

iOSRenderExtraFrameOnPause: 0
iosCopyPluginsCodeInsteadOfSymlink: 0
appleDeveloperTeamID:
appleDeveloperTeamID: 97JCY7859U

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed Apple team identifier

Low Severity

This change sets a concrete appleDeveloperTeamID in the shared Unity 2021 sample while the PR moves team setup to APPLE_ID via samples-setup-apple-id.ps1. That pins one developer team in repo history and can confuse iOS signing for other contributors.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c765751. Configure here.

@bitsandfoxes
bitsandfoxes merged commit c6632c1 into main Jul 28, 2026
37 of 38 checks passed
@bitsandfoxes
bitsandfoxes deleted the chore/agent-test-harness branch July 28, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants