Skip to content

fix(system): handle command-check and version parse failures#349

Merged
MuncleUscles merged 2 commits into
v0.39from
codex/fix-system-command-check-v039
Jun 11, 2026
Merged

fix(system): handle command-check and version parse failures#349
MuncleUscles merged 2 commits into
v0.39from
codex/fix-system-command-check-v039

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Fixes #301.
Fixes #303.
Supersedes #337 because the contributor fork branch could not be updated from this environment.

Changes:

  • Treat any failed command check as a missing requirement instead of only checking stderr/ENOENT.
  • Throw explicit parse errors when tool version output does not contain an X.Y.Z version.
  • Add regression coverage for ENOENT, empty/non-matching version output, and command failures without stderr.

Verification:

  • npm run test -- tests/libs/system.test.ts
  • npm run test:coverage
  • npm run build

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80757cd1-ce2c-494c-a034-6a4304505450

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-system-command-check-v039

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MuncleUscles MuncleUscles merged commit 5b93dd3 into v0.39 Jun 11, 2026
3 of 7 checks passed
MuncleUscles added a commit that referenced this pull request Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants