ci(deploy): fail loudly when Cloudflare cache purge fails - #63
Merged
Conversation
The Purge Cloudflare Cache step used a bare curl and never checked the response - the Cloudflare purge API returns HTTP 200 even on auth failure, so a broken CLOUDFLARE_API_TOKEN (currently: error code 10000) silently left the edge cache un-invalidated on every deploy, serving stale content. The step now parses the JSON `success` field via jq and exits 1 with a `::error::` annotation when purge fails, naming the likely fix (token needs Zone.Cache Purge:Edit). The Cloudflare Pages deployment itself is a prior step and still completes; only the purge substep now surfaces the failure.
Deploying gemmology-dev with
|
| Latest commit: |
de24634
|
| Status: | 🚫 Build failed. |
|
🚀 Preview deployed to: https://44ff5074.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLOUDFLARE_API_TOKENsilently left the edge cache un-invalidated on every deploy, serving stale content.successfield via jq and exits 1 with a::error::annotation when purge fails, naming the likely fix (token needs Zone.Cache Purge:Edit).Test plan