Skip to content

fix(hero): aim the hero camera at the crystal so it renders centred in the canvas #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bissbert merged 1 commit into from
Jul 17, 2026
Merged

fix(hero): aim the hero camera at the crystal so it renders centred in the canvas #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/components/crystal/HeroCrystal3D.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/

import { Canvas, useFrame } from '@react-three/fiber';
import { Center, Edges } from '@react-three/drei';
import { Edges } from '@react-three/drei';
import { Suspense, useRef, useState, useEffect } from 'react';
import * as THREE from 'three';
import { GLTFLoader } from 'three/examples/jsm/loaders/GLTFLoader.js';
Expand Down Expand Up @@ -231,19 +231,22 @@ export function HeroCrystal3D({
gl={{ antialias: true, alpha: true }}
dpr={[1, 2]}
style={{ background: 'transparent' }}
// R3F treats `camera` as construction-only and never orients it, so a
// custom position leaves the camera facing world -Z instead of the
// crystal. Aim it at the origin (where geometry.center() puts the
// crystal's centroid) so it renders centred in the canvas.
onCreated={({ camera }) => camera.lookAt(0, 0, 0)}
>
<Suspense fallback={<LoadingFallback rotationSpeed={effectiveRotation} />}>
<ambientLight intensity={0.4} />
<directionalLight position={[5, 5, 5]} intensity={0.8} />
<directionalLight position={[-3, 3, -3]} intensity={0.3} />

<Center>
{geometry ? (
<RotatingCrystal geometry={geometry} rotationSpeed={effectiveRotation} scale={scale} />
) : (
<LoadingFallback rotationSpeed={effectiveRotation} />
)}
</Center>
{geometry ? (
<RotatingCrystal geometry={geometry} rotationSpeed={effectiveRotation} scale={scale} />
) : (
<LoadingFallback rotationSpeed={effectiveRotation} />
)}
</Suspense>
</Canvas>
</div>
Expand Down
Loading