Skip to content

fix(hero): centre the home hero crystal so it spins in place #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bissbert merged 1 commit into from
Jul 17, 2026
Merged

fix(hero): centre the home hero crystal so it spins in place #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/crystal/HeroCrystal3D.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ function parseGLTFToGeometry(gltfData: any): THREE.BufferGeometry | null {
geometry.setAttribute('normal', new THREE.BufferAttribute(normData, 3));
geometry.setIndex(new THREE.BufferAttribute(idxData, 1));

// Center the geometry on its own centroid so it spins in place. Without
// this the crystal's centre is offset from the group origin, so it orbits
// the origin as it auto-rotates and drifts off-centre (matches the working
// Crystal3DViewer, which centres the same way).
geometry.center();
geometry.computeBoundingSphere();

return geometry;
} catch (error) {
console.error('Error parsing glTF:', error);
Expand Down Expand Up @@ -230,7 +237,7 @@ export function HeroCrystal3D({
<directionalLight position={[5, 5, 5]} intensity={0.8} />
<directionalLight position={[-3, 3, -3]} intensity={0.3} />

<Center position={[0, 0.15, 0]}>
<Center>
{geometry ? (
<RotatingCrystal geometry={geometry} rotationSpeed={effectiveRotation} scale={scale} />
) : (
Expand Down
Loading