fix(learn): pin desktop TOC on scroll + mobile bottom-sheet section switcher - #57
Merged
Conversation
…witcher - desktop TOC rail was never actually sticky on scroll - the grid's items-start shrink-wrapped the TOC cell so position:sticky had no travel room; fixed with lg:self-stretch on the TOC cell (measured pinned at top:80px through scrollY 4000) - mobile "On this page" floating thumb-zone button opens a native <dialog> bottom sheet (focus trap, Escape/backdrop/link-tap dismiss, focus restore, reduced-motion + both themes), replacing the top-of-article details that scrolled out of reach - one shared IntersectionObserver keeps scroll-spy in sync across desktop rail + mobile sheet 502 tests, browser scroll-verified.
|
🚀 Preview deployed to: https://cf6f678f.gemmology-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
items-startshrink-wrapped the TOC cell soposition: stickyhad no travel room; fixed withlg:self-stretchon the TOC cell (measured pinned attop: 80pxthroughscrollY4000)<dialog>bottom sheet (focus trap, Escape/backdrop/link-tap dismiss, focus restore, reduced-motion + both themes), replacing the top-of-article details that scrolled out of reachTest plan