fix(learn): sticky TOC, 18px body measure, unified fact lists, citation landing feedback - #55
Merged
Merged
Conversation
…on landing feedback - in-page table of contents for long articles (sticky desktop rail w/ IntersectionObserver scroll-spy + mobile collapsible details, >=4-section gate) fed by a shared section-id helper so anchors always match - body text now renders at the intended 18px / ~70ch measure (propagated prose-lg into SectionRenderer's nested prose scopes; tables unaffected) - PropertyList converged to a semantic single-column dl/dt/dd (unifies the three name/value fact grammars, better screen-reader semantics) - citation superscripts get an explicit light-mode crystal color + a :target landing flash on the referenced bibliography row (light/dark tints, reduced-motion fallback) - fixes: hub "Start here" 5th card (slug pointed at a bare directory, now .../overview), 390px filter placeholder clipping, DataTable mobile overflow fade hint - docs/authoring-learn.md documents when to use items:/table:/prose 502 tests, browser-verified in both themes.
|
🚀 Preview deployed to: https://e73d65fb.gemmology-dev.pages.dev |
4 tasks
Bissbert
added a commit
that referenced
this pull request
Jul 16, 2026
…-link & citation-flash polish (#56) - subsections now render comparison/callout/crystal fields (subsectionSchema + Subsection interface + render branches were missing them) — restores 10 silently-dropped content blocks across 6 articles incl. crystallography-advanced's Open-vs-Closed comparison and 3 CDL-example demos, plus a dev-mode warning for unhandled subsection keys - fixes a secondary crystal-subsection misroute into CrystalSystemCard - fixes ordered-list counter-badge overlap under prose-lg (replicated custom ol/li/::before rules into typography.lg — regression from PR #55) - reference DOI/URL links now visible (crystal-700 + underline) in light mode for WCAG 1.4.1 - citation :target flash lengthened to ~2.6s hold-then-fade - learn hub intro broken into a scannable value-line + 3-item feature list - 502 tests, browser-verified both themes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<details>version, gated to articles with 4+ sections, fed by a shared section-id helper so anchors always match headings.prose-lgintoSectionRenderer's nested prose scopes (tables are unaffected).PropertyListconverged to a semantic single-columndl/dt/dd, unifying the three name/value fact grammars and improving screen-reader semantics.:targetlanding flash on the referenced bibliography row, with light/dark tints and a reduced-motion fallback..../overview), 390px filter placeholder clipping,DataTablemobile overflow fade hint.docs/authoring-learn.mddocuments when to useitems:/table:/prosein learn content YAML.Test plan
npm run test -- --run— 502 tests passing