chore(payments): Clean unused code

[Quentin-David-24]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba4e281b-0651-45e3-89f2-623de948c378

📥 Commits

Reviewing files that changed from the base of the PR and between 693c58e and 3fe0b7e.

📒 Files selected for processing (13)

• cmd/payments/connectors/uninstall.go
• cmd/payments/connectors/views/adyen.go
• cmd/payments/connectors/views/atlar.go
• cmd/payments/connectors/views/coinbaseprime.go
• cmd/payments/connectors/views/column.go
• cmd/payments/connectors/views/fireblocks.go
• cmd/payments/connectors/views/increase.go
• cmd/payments/connectors/views/mangopay.go
• cmd/payments/connectors/views/plaid.go
• cmd/payments/connectors/views/powens.go
• cmd/payments/connectors/views/qonto.go
• cmd/payments/connectors/views/stripe.go
• cmd/payments/connectors/views/tink.go

💤 Files with no reviewable changes (13)

• cmd/payments/connectors/views/increase.go
• cmd/payments/connectors/views/powens.go
• cmd/payments/connectors/views/plaid.go
• cmd/payments/connectors/views/qonto.go
• cmd/payments/connectors/views/coinbaseprime.go
• cmd/payments/connectors/views/column.go
• cmd/payments/connectors/views/tink.go
• cmd/payments/connectors/uninstall.go
• cmd/payments/connectors/views/fireblocks.go
• cmd/payments/connectors/views/mangopay.go
• cmd/payments/connectors/views/atlar.go
• cmd/payments/connectors/views/adyen.go
• cmd/payments/connectors/views/stripe.go

---

Walkthrough

The changes remove legacy V3 connector configuration display functions, update remaining connector views, and simplify uninstall command option wiring while preserving zero-argument enforcement.

Changes

Connector uninstall command

Layer / File(s)	Summary
Remove uninstall validation wiring cmd/payments/connectors/uninstall.go	Removes the internal connector import and valid-argument option; cobra.ExactArgs(0) remains enforced.

Connector configuration views

Layer / File(s)	Summary
Consolidate connector configuration displays cmd/payments/connectors/views/*.go	Removes V3-specific display helpers for Adyen, Atlar, Coinbase Prime, Column, Fireblocks, Increase, MangoPay, Plaid, Powens, Qonto, Stripe, and Tink. Atlar uses the non-V3 response with transfer initiation polling and pointer-safe BaseUrl rendering; MangoPay and Stripe retain non-V3 display paths with local polling-period handling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: laouji, gfyrag

Poem

A rabbit hops through tables bright,
Old V3 rows vanish from sight.
The uninstall path grows clean and bare,
While Atlar’s fields receive due care.
MangoPay keeps its polling tune—
A tidy CLI beneath the moon.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided, so there is nothing substantive to evaluate.	Add a short description summarizing the cleanup of unused payment connector code and removed V3 view helpers.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the change set, which removes unused payment connector code.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/payments-clean

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NumaryBot]

✅ Approve — automated review

The removed V3 display helpers and uninstall valid-args wiring are not referenced by the current code paths, and the remaining code appears consistent with the existing generic V3 config rendering.

No findings.

[flemzord]

@Quentin-David-24 Could we not activate the unused in the linter?

[Quentin-David-24]

@flemzord Unused is activated but those are not detected since those are exported function (Capitalized).

But since fctl is a binary and not a library, we do not really want this.
We could integrate some tools like https://pkg.go.dev/golang.org/x/tools/cmd/deadcode.

Wdyt?