feat(flow-php/etl): partition placeholders in read/write paths#2509
Merged
Conversation
- {column} placeholders in destination paths turn partitions into
file/directory names
- placeholders in extractor paths match like wildcards and recover
partition values, incl. pruning
- Partition name and value now forbid { and } (breaking, upgrade note
added)
- save modes (overwrite/append) applied to resolved placeholder paths
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2509 +/- ##
============================================
+ Coverage 85.90% 85.92% +0.01%
- Complexity 0 21923 +21923
============================================
Files 1652 1653 +1
Lines 67527 67687 +160
============================================
+ Hits 58011 58161 +150
- Misses 9516 9526 +10 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2238
Change Log
Added
flow-php/filesystem-{column}partition placeholders in paths with extraction, glob listing and filter supportflow-php/etl- writing partitions into file/directory names via placeholders in destination pathsflow-php/etl- reading placeholder paths recovers partitions from file names, including partition pruningFixed
Changed
flow-php/filesystem-Partitionname and value now forbid{and}charactersRemoved
Deprecated
Security