Skip to content

chore: move attestation-provider-server crate from proxy repo#17

Merged
ameba23 merged 1 commit into
flashbots:mainfrom
steph-rs:steph-rs/chore/move-attestation-provider-server
Jun 10, 2026
Merged

chore: move attestation-provider-server crate from proxy repo#17
ameba23 merged 1 commit into
flashbots:mainfrom
steph-rs:steph-rs/chore/move-attestation-provider-server

Conversation

@steph-rs

@steph-rs steph-rs commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

This PR moves attestation-provider-server crate from proxy repo.
As discussed in flashbots/attested-tls-proxy#156.

Changes:

  • replaced attested-tls-proxy dependency with direct attestation path dependency
  • fmt
  • used tokio from workspace dependencies

@ameba23 ameba23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

Will also get @0x416e746f6e to take a look.

For context, this moves the crate as-is over from the attested-tls-proxy repo, as it is more related to the contents of this repo than to the proxy.

@ameba23 ameba23 requested a review from 0x416e746f6e April 3, 2026 09:12

@0x416e746f6e 0x416e746f6e left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this contribution.

small nit: can the provider server be made to fail with error if attestation type detection fails?

Comment on lines +14 to +15
attestation = { path = "../attestation" }
tokio.workspace = true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Suggested change
attestation = { path = "../attestation" }
tokio.workspace = true
attestation = { workspace = true }
tokio = { workspace = true }

@0x416e746f6e

Copy link
Copy Markdown
Member

p.s. also, could you please rebase this PR @steph-rs?

@steph-rs

steph-rs commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

yeah, I'll do fixes and rebase in a few days. happy to help

@ameba23

ameba23 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

yeah, I'll do fixes and rebase in a few days. happy to help

@steph-rs gentle reminder about this. i can take it on if you are busy with other stuff these days.

@steph-rs

steph-rs commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

I apologize for the delay. I've been busy with a lot of things. I remember this PR, and I'm going to do it today, I promise.

@ameba23

ameba23 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

I apologize for the delay. I've been busy with a lot of things.

No worries, we know how it is 😉

@steph-rs steph-rs force-pushed the steph-rs/chore/move-attestation-provider-server branch from 3db69f3 to bbd26f0 Compare June 9, 2026 23:28
@steph-rs

steph-rs commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

hey @ameba23, as promised 🙏

@ameba23 ameba23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @steph-rs

Approving - but merging is blocked due to unsigned commits. Not sure what to do about this - i think this is an org-wide setting rather than a repo setting. Any ideas @0x416e746f6e ?

Don't want to keep making more work for you @steph-rs but if you were willing to squash these changes into a signed commit that would be great.

@0x416e746f6e

Copy link
Copy Markdown
Member

Don't want to keep making more work for you @steph-rs but if you were willing to squash these changes into a signed commit that would be great.

if that doesn't work, we can always squash ourselves and simply mention @steph-rs as the author

@steph-rs steph-rs force-pushed the steph-rs/chore/move-attestation-provider-server branch from 4fcf8dc to e4fb288 Compare June 10, 2026 08:07
@ameba23 ameba23 merged commit 1c7b334 into flashbots:main Jun 10, 2026
1 check passed
@steph-rs steph-rs deleted the steph-rs/chore/move-attestation-provider-server branch June 10, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants