chore: move attestation-provider-server crate from proxy repo#17
Conversation
ameba23
left a comment
There was a problem hiding this comment.
Great! Thank you.
Will also get @0x416e746f6e to take a look.
For context, this moves the crate as-is over from the attested-tls-proxy repo, as it is more related to the contents of this repo than to the proxy.
0x416e746f6e
left a comment
There was a problem hiding this comment.
thanks for this contribution.
small nit: can the provider server be made to fail with error if attestation type detection fails?
| attestation = { path = "../attestation" } | ||
| tokio.workspace = true |
There was a problem hiding this comment.
suggestion:
| attestation = { path = "../attestation" } | |
| tokio.workspace = true | |
| attestation = { workspace = true } | |
| tokio = { workspace = true } |
|
p.s. also, could you please rebase this PR @steph-rs? |
|
yeah, I'll do fixes and rebase in a few days. happy to help |
@steph-rs gentle reminder about this. i can take it on if you are busy with other stuff these days. |
|
I apologize for the delay. I've been busy with a lot of things. I remember this PR, and I'm going to do it today, I promise. |
No worries, we know how it is 😉 |
3db69f3 to
bbd26f0
Compare
|
hey @ameba23, as promised 🙏 |
There was a problem hiding this comment.
Thank you @steph-rs
Approving - but merging is blocked due to unsigned commits. Not sure what to do about this - i think this is an org-wide setting rather than a repo setting. Any ideas @0x416e746f6e ?
Don't want to keep making more work for you @steph-rs but if you were willing to squash these changes into a signed commit that would be great.
4fcf8dc to
e4fb288
Compare
This PR moves
attestation-provider-servercrate from proxy repo.As discussed in flashbots/attested-tls-proxy#156.
Changes:
attested-tls-proxydependency with directattestationpath dependencytokiofrom workspace dependencies