Move GR-specific payItem mappings into the Greek market reference table#55
Open
StefanKert wants to merge 1 commit into
Open
Move GR-specific payItem mappings into the Greek market reference table#55StefanKert wants to merge 1 commit into
StefanKert wants to merge 1 commit into
Conversation
The general ftPayItemCase (PP - Payment type) table carried a market-specific "GR" column. Move those mappings into the Greek market doc as a dedicated "Maps to (Greek payment method)" column, and remove the column from the general table so it stays market-neutral, consistent with how ftReceiptCase, ftSignatureType, etc. are structured. Also drop the per-row "cash"/"noncash" sub-labels in the GR table: they were copy-paste boilerplate (identical to the Belgium doc) and self-contradictory (e.g. "NonCash" labelled "cash"), carrying no GR-specific meaning. Ref: fiskaltrust/service-docs-ui#20 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The general
ftPayItemCasereference table carried a market-specificGRcolumn. This moves that GR-specific content into the Greek market doc where it belongs, and removes the column from the general (market-neutral) table.Addresses fiskaltrust/service-docs-ui#20.
What changed
general/reference-tables/reference-tables.mdGRcolumn from thePP - Payment typetable. The general table is now market-neutral, consistent with howftReceiptCase,ftSignatureType, etc. are structured — market specifics live in each market's doc.middleware-gr/reference-tables/type-of-payment-ftpayitemcase.mdAdded a
Maps to (Greek payment method)column carrying the mappings that previously lived in the general table'sGRcolumn:01Cash03Crossed cheque04/05Debit / Credit card06Voucher09Accounts receivable0ASEPA transferDescription == "IRIS"→ IRIS ·Description == "RF code payment (Web banking)"→ Web banking0BOther bank transferRemoved the per-row
cash/noncashsub-labels. They were copy-paste boilerplate (byte-identical to the Belgium doc) and self-contradictory (e.g.NonCashlabelledcash), so they carried no GR-specific meaning.Notes for the reviewer
#type-of-payment-ftpayitemcase) is unchanged, so existing cross-links (GR / AT / BE / …) still resolve.ftChargeItemCase → NN (Nature of VAT)table still has inlineITandGRcolumns — the same "market-specific content in the general table" pattern. Left untouched here since the issue is payItem-only; worth a follow-up.🤖 Generated with Claude Code