Skip to content

Rename lifecycle events to match functions vocabulary#10767

Merged
wandamora merged 1 commit into
mainfrom
morawand-rename-lifecycle-events
Jul 7, 2026
Merged

Rename lifecycle events to match functions vocabulary#10767
wandamora merged 1 commit into
mainfrom
morawand-rename-lifecycle-events

Conversation

@wandamora

Copy link
Copy Markdown
Contributor

Description

This PR refactors lifecycle hook event naming and helper structures to better mirror Cloud Functions terminology and move away from Extensions terms (afterInstall, afterUpdate).

  • Renamed event strings:
    • afterInstall is renamed to afterFirstDeploy
    • afterUpdate is renamed to afterRedeploy
  • Renamed types and methods:
    • Type LifecycleDelta is renamed to DeploymentEvent
    • Helper function determineDeploymentDelta is renamed to determineDeploymentEvent
  • Internal variable renaming:
    • Updated occurrences of delta variables/parameters to event to correspond with DeploymentEvent.

Scenarios Tested

Sample Commands

  • firebase functions:lifecycle:run afterFirstDeploy default
  • firebase functions:lifecycle:run afterRedeploy default
  • firebase functions:lifecycle:list default

@wandamora wandamora requested review from ajperel and inlined July 7, 2026 15:03

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the lifecycle hooks from afterInstall and afterUpdate to afterFirstDeploy and afterRedeploy respectively, updating all associated types, functions, and tests. The feedback suggests using the newly defined DeploymentEvent type instead of string in the executeHook function signature to improve type safety.

Comment thread src/deploy/functions/release/lifecycle.ts Outdated
@wandamora wandamora force-pushed the morawand-rename-lifecycle-events branch from f26b6f9 to fc11466 Compare July 7, 2026 15:23
This renames afterInstall to afterFirstDeploy and afterUpdate to
afterRedeploy to better mirror functions vocabulary and move away
from Extensions terms.
@wandamora wandamora force-pushed the morawand-rename-lifecycle-events branch from fc11466 to 2f60d84 Compare July 7, 2026 18:42
@wandamora wandamora merged commit e7b3f81 into main Jul 7, 2026
53 checks passed
@wandamora wandamora deleted the morawand-rename-lifecycle-events branch July 7, 2026 19:24
@wandamora wandamora restored the morawand-rename-lifecycle-events branch July 7, 2026 19:37
@wandamora wandamora deleted the morawand-rename-lifecycle-events branch July 8, 2026 15:03
bkendall pushed a commit that referenced this pull request Jul 9, 2026
This renames afterInstall to afterFirstDeploy and afterUpdate to
afterRedeploy to better mirror functions vocabulary and move away
from Extensions terms.
bkendall pushed a commit that referenced this pull request Jul 9, 2026
This renames afterInstall to afterFirstDeploy and afterUpdate to
afterRedeploy to better mirror functions vocabulary and move away
from Extensions terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants