Add Recaptcha App Check Provider stubs#1860
Open
a-maurice wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the RecaptchaEnterpriseProviderFactory for App Check, adding the header and stub implementation files and updating CMakeLists.txt. The review feedback highlights a critical path error in CMakeLists.txt where the header path is missing the 'app_check/' subdirectory, and recommends initializing the 'internal_' member pointer to nullptr in the constructor to prevent undefined behavior.
| src/include/firebase/app_check/play_integrity_provider.h | ||
| src/include/firebase/app_check/device_check_provider.h | ||
| src/include/firebase/app_check/app_attest_provider.h | ||
| src/include/firebase/recaptcha_enterprise_provider.h |
Contributor
There was a problem hiding this comment.
| return nullptr; | ||
| } | ||
|
|
||
| RecaptchaEnterpriseProviderFactory::RecaptchaEnterpriseProviderFactory() {} |
Contributor
There was a problem hiding this comment.
The member variable internal_ is left uninitialized in the constructor. It is best practice to initialize member pointers to nullptr to prevent undefined behavior or garbage values.
Suggested change
| RecaptchaEnterpriseProviderFactory::RecaptchaEnterpriseProviderFactory() {} | |
| RecaptchaEnterpriseProviderFactory::RecaptchaEnterpriseProviderFactory() : internal_(nullptr) {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add stub implementations for a new built-in provider, Recaptcha Enterprise. This is stubbed on all platforms, and will eventually be implemented for both Android and iOS.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.