dataconnect.py: add "X-Firebase-Sqlconnect-Affinity" header for GSLB soft stickiness - #972
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the 'X-Firebase-Sqlconnect-Affinity' header to the Data Connect client requests and updates the corresponding tests. The feedback suggests removing redundant parentheses around the new header's f-string value to maintain style consistency and improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
X-Firebase-Sqlconnect-AffinityHTTP request header to outgoing Data Connect HTTP requests. This header enables backend server affinity routing for SQL Connect to improve server resource usage efficiency and performance.Highlights
X-Firebase-Sqlconnect-Affinityheader containingf"{self._project_id}{self._connector_config.service_id}"to Data Connect API client requests.test_get_headers()intest_data_connect.pyto verify the header key and formatted value.Changelog
X-Firebase-Sqlconnect-Affinityheader (f"{self._project_id}{self._connector_config.service_id}") in_DataConnectApiClient._get_headers().X-Firebase-Sqlconnect-Affinityheader intest_get_headers().