feat(dataconnect): add "X-Client-Version" header for cloud monitoring - #971
Merged
Conversation
Googlers see go/dataconnect:sdk:headers for details
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the 'X-Client-Version' header to the HTTP headers returned by the Data Connect client in 'firebase_admin/dataconnect.py', and updates the corresponding unit tests in 'tests/test_data_connect.py' to verify its presence and value. There are no review comments, and I have no feedback to provide.
dconeybe
changed the title
dconeybe
marked this pull request as ready for review
July 30, 2026 21:41
mk2023
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
X-Client-Versionrequest header (formatted aspython/<version>) to_DataConnectApiClientto enable metrics collection in Cloud Monitoring.Highlights
X-Client-Versionheader (set topython/{firebase_admin.__version__}) to outgoing requests in_DataConnectApiClientto enable Cloud Monitoring telemetry.X-Client-Versionis correctly attached to API client requests.Changelog
_headersto include theX-Client-Versionheader formatted aspython/{firebase_admin.__version__}in default request headers.TestDataConnectApiClientGetHeadersto verifyX-Client-Versionis included in request headers.