Skip to content

fby4: wf: Add support for WF SKU without ASIC - #2747

Closed
Wiwynn-Evan wants to merge 1 commit into
facebook:mainfrom
Wiwynn:SeanHe/YV4/WF_without_ASIC/v2026.30.e2
Closed

fby4: wf: Add support for WF SKU without ASIC#2747
Wiwynn-Evan wants to merge 1 commit into
facebook:mainfrom
Wiwynn:SeanHe/YV4/WF_without_ASIC/v2026.30.e2

Conversation

@Wiwynn-Evan

Copy link
Copy Markdown
Contributor

Related JIRA ticket:

YV4T1M-2363

[Description]

  • Implement code to support WF SKU variant without ASIC

[Motivation]

  • New WF board variant requires special handling to operate without ASIC components

[Design]

  • Detect the specific WF SKU by measuring voltage on ADC0 channel:
    • Original WF: 1.5V
    • New WF (no ASIC): 0.75V
  • Query blade configuration during initialization to determine appropriate power sequence
  • Execute power sequence while bypassing ASICs
  • Modify FW behavior when specific WF configuration is detected:
    • Disable ASIC-related sensors in BIC FW
    • Disable ASIC-related VR fault reporting in ISR
    • Disable downstream devices for PLDM FW updates

[Test Plan]

(1) Build: pass
(2) Test on Yv4: pass

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
@meta-codesync

meta-codesync Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D113218924. (Because this pull request was imported automatically, there will not be any future comments.)

@jamesatha jamesatha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a valid lint error. Please fix

uint8_t ioe2_output_value = 0;

if (get_ioe_value(ADDR_IOE2, TCA9555_OUTPUT_PORT_REG_0, &ioe2_output_value) == 0) {
CLEARBITS(ioe2_output_value, IOE_P00,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address this lint error

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, added the missing semicolon. Thanks for catching this!

Summary:
[Task Description]
- Implement code to support WF SKU variant without ASIC (YV4T1M-2363)

[Motivation]
- New WF board variant requires special handling to operate without ASIC components

[Design]
- Detect the specific WF SKU by measuring voltage on ADC0 channel:
  * Original WF: 1.5V
  * New WF (no ASIC): 0.75V
- Query blade configuration during initialization to determine appropriate power sequence
- Execute power sequence while bypassing ASICs
- Modify FW behavior when specific WF configuration is detected:
  * Disable ASIC-related sensors in BIC FW
  * Disable ASIC-related VR fault reporting in ISR
  * Disable downstream devices for PLDM FW updates
@MandyMCHung
MandyMCHung force-pushed the SeanHe/YV4/WF_without_ASIC/v2026.30.e2 branch from 289277b to 6df9d12 Compare July 23, 2026 02:21
@facebook-github-tools

Copy link
Copy Markdown

@Wiwynn-Evan has updated the pull request. You must reimport the pull request before landing.

@meta-codesync meta-codesync Bot closed this in f4ff3c9 Jul 23, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

This pull request has been merged in f4ff3c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants