chore: remove dead code and reclassify test-only dependencies#242
Open
matt-evervault wants to merge 1 commit into
Open
chore: remove dead code and reclassify test-only dependencies#242matt-evervault wants to merge 1 commit into
matt-evervault wants to merge 1 commit into
Conversation
Delete unused internal modules that were unreachable from the public API: - lib/core/labs.js + lib/core/labs/index.js (legacy `proxy-cage` helper) - lib/utils/dataHelper.js (imported `big.js`, which was never a declared dependency, and was referenced nowhere) - lib/utils/environment.js (legacy Function env-var extraction, unused) Move `crc-32` and `uuid` to devDependencies since they are only used by the test suite, not by lib/. Remove the leftover EV_CAGE_RUN_URL reference from the config test (the env var no longer exists in config). Test baseline unchanged: 204 passing (the 5 pre-existing proxy.test.js failures are environmental and unrelated to this change). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011HwoTRLdV2YMub47j88mv5
🦋 Changeset detectedLatest commit: d8e4ceb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First branch in a staged modernization of the Node SDK. It removes unreachable dead code and tidies dependency classification, so the following TypeScript-conversion branch has a smaller, cleaner surface to convert.
How
lib/core/labs.js(+lib/core/labs/index.js, the legacyproxy-cagehelper),lib/utils/dataHelper.js(importedbig.js, which was never a declared dependency — a latent crash), andlib/utils/environment.js(unused legacy Function env extraction).crc-32anduuidtodevDependencies— both are only used by the test suite, not bylib/.EV_CAGE_RUN_URLreference from the config test.Test baseline unchanged: 204 passing (the 5
proxy.test.jsfailures are pre-existing and environmental).Part of a stacked series for reviewability — this targets the pnpm/Node-migration base; the TypeScript conversion (
claude/sdk-typescript) stacks on top of it.🤖 Generated with Claude Code
https://claude.ai/code/session_011HwoTRLdV2YMub47j88mv5
Generated by Claude Code