chore: sync uutils/coreutils argument surfaces and integrate new i18n-decimal gate#2161
Merged
Conversation
… modules Regenerated by `bashkit-coreutils-port` against uutils/coreutils@4988134fa. Utilities: cat ls mktemp od readlink realpath shuf stat tac tee truncate Vendored modules: format
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 0914be7 | Commit Preview URL Branch Preview URL |
Jul 13 2026, 09:52 AM |
The uutils HEAD sync pulled two changes that the drift pipeline did not yet handle: - format/human.rs now carries `#[cfg(feature = "i18n-decimal")]`. bashkit has no i18n surface (the port tool hard-errors on Fluent/translate), so the feature is never defined and the gated branch is compiled out. Declare it via a [lints.rust] check-cfg so `unexpected_cfgs` (denied by -D warnings) stops flagging the vendored code. - module-mode output (format/, num_parser.rs, extendedbigdecimal.rs) was never run through rustfmt; the args step only formats top-level generated/*.rs. Add a fmt step over the whole generated/ tree so future drift runs stay rustfmt-clean, and format the current output. Verified locally: cargo build -p bashkit (RUSTFLAGS=-D warnings), cargo clippy -p bashkit --lib, and cargo fmt --check all pass.
chaliy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Lands the weekly
coreutils-args-driftsync plus the integration work the raw regeneration needed to build cleanly.33f4610, produced by the drift workflow): regenerate argument surfaces and the vendoredformatmodule against uutils HEAD.4988134fa(was39364b6)0914be7):format/human.rsnow carries#[cfg(feature = "i18n-decimal")]. bashkit has no i18n surface (the port tool hard-errors on Fluent/translate), so the feature is never defined and the gated branch is compiled out. Declared via a[lints.rust]check-cfgincrates/bashkit/Cargo.tomlsounexpected_cfgs(denied by-D warnings) stops flagging the vendored code.cargo fmtstep overgenerated/tocoreutils-args-drift.ymlso module-mode output (format/,num_parser.rs,extendedbigdecimal.rs) is formatted on every run, and formatted the current output.Why
After the drift-guard push bug was fixed (#2159), the re-dispatched run pushed this branch successfully, but its CI failed:
error: unexpected 'cfg' condition value: 'i18n-decimal'(-D warnings).cargo fmtdiff on the un-formatted module-mode output.Both are consequences of upstream drift the pipeline didn't yet handle; this PR handles them durably.
Before / After
Verified locally against this branch's content:
cargo build -p bashkit(with-D warnings) → 2 errors on thei18n-decimalcfg;cargo fmt --check→ diffs in the module output.RUSTFLAGS="-D warnings" cargo build -p bashkit→Finished✅cargo clippy -p bashkit --lib→ clean ✅cargo fmt --check→ clean ✅BASHKIT_RUN_COREUTILS_DIFF=1) against uutils4988134fa.Risk
i18n-decimalbranch referencescrate::i18n(absent in bashkit) but is always compiled out since the feature is never enabled.Checklist