Fix assigned TypeScript namespace aliases#4470
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4450.
TypeScript namespace alias lowering already rewrites reads from exported members in sibling namespace blocks, such as
console.log(x)becomingA.x. The assignment target path was skipping the namespace alias rewrite, sox = 0stayed as a bare identifier.This change keeps enum/namespace member inlining limited to read-only references, but still lowers assigned namespace aliases to property accesses. I also added a regression test for the sibling namespace assignment case from the issue.
Tests:
go test ./internal/js_parser -run TestTSNamespaceExportsgo test ./internal/js_parsergo test ./internal/... ./pkg/...make test-go