feat(api): annotate HTTP spans with status and semantic attributes#5503
Open
gacevicljubisa wants to merge 1 commit into
Open
feat(api): annotate HTTP spans with status and semantic attributes#5503gacevicljubisa wants to merge 1 commit into
gacevicljubisa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Makes HTTP API spans queryable in Tempo and tidies tracing naming. Beacuse failed HTTP requests couldn't be filtered by
status=errorand Grafana's HTTP/APM views had nothing to key off. Complements #5502's node-level resource/baggage work at the request level.newTracingHandler: setSpanKind=Server, addhttp.request.method/http.route/http.response.status_code, and map 5xx → span statusError(4xx stays Unset, still queryable via the status-code attribute).
tagID→tag_id(pushsync, bytes, bzz) forlower_snake_caseconsistency.post_bytes/post_bzz→bytes-post/bzz-post(logger tree names left unchanged).
tracing.NewTracerFromProvider+ a unit test covering the 200 and 500 paths.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure