You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Brief description of code changes (suitable for use as a commit message):
Allow --zerocopy and --skip-rx-copy even when one of the sides OS, client or server, not support them, as they may be supported by the other side. When not supported, allow zerocopy only when not sending and skip-rx-copy only when not receiving.
(UPDATE note: deleted the -P related changes and created a separate PR for them.)
Thanks for the pull request. I'm trying to test it, but it looks like this is a fix (with respect to --zerocopy and --skip-rx-copy for a problem that does not occur on Linux, FreeBSD, or macOS (the three main development problems). If this is only an issues (a platfom that we don't officially support) this is going to be a little hard for our team to test. Haven't quiet figured out how to deal with this yet.
Haven't quiet figured out how to deal with this yet.
I tested it by creating a version with HAVE_MSG_TRUNC set to zero, and then run it once as a client and once as a server (when the other side is the version with HAVE_MSG_TRUNC set to 1). I believe this is sufficient as each of these options affect either sending or sides but not both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master 3.21+
Issues fixed (if any): zerocopy os check should wait for sever response when in reverse mode #2044
Brief description of code changes (suitable for use as a commit message):
Allow
--zerocopyand--skip-rx-copyeven when one of the sides OS, client or server, not support them, as they may be supported by the other side. When not supported, allowzerocopyonly when not sending andskip-rx-copyonly when not receiving.(UPDATE note: deleted the
-Prelated changes and created a separate PR for them.)