Skip to content

Allow --zerocopy and --skip-rx-copy when only server supports, fix -P value verification#2045

Open
davidBar-On wants to merge 1 commit into
esnet:masterfrom
davidBar-On:issue_2044_options_verify_enhance__zerocopy_skip-rx-copy_parallel
Open

Allow --zerocopy and --skip-rx-copy when only server supports, fix -P value verification#2045
davidBar-On wants to merge 1 commit into
esnet:masterfrom
davidBar-On:issue_2044_options_verify_enhance__zerocopy_skip-rx-copy_parallel

Conversation

@davidBar-On

@davidBar-On davidBar-On commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Allow --zerocopy and --skip-rx-copy even when one of the sides OS, client or server, not support them, as they may be supported by the other side. When not supported, allow zerocopy only when not sending and skip-rx-copy only when not receiving.

(UPDATE note: deleted the -P related changes and created a separate PR for them.)

@bmah888

bmah888 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thanks for the pull request. I'm trying to test it, but it looks like this is a fix (with respect to --zerocopy and --skip-rx-copy for a problem that does not occur on Linux, FreeBSD, or macOS (the three main development problems). If this is only an issues (a platfom that we don't officially support) this is going to be a little hard for our team to test. Haven't quiet figured out how to deal with this yet.

@davidBar-On davidBar-On deleted the issue_2044_options_verify_enhance__zerocopy_skip-rx-copy_parallel branch June 13, 2026 09:02
@davidBar-On davidBar-On restored the issue_2044_options_verify_enhance__zerocopy_skip-rx-copy_parallel branch June 13, 2026 09:02
@davidBar-On davidBar-On reopened this Jun 13, 2026
@davidBar-On davidBar-On force-pushed the issue_2044_options_verify_enhance__zerocopy_skip-rx-copy_parallel branch from 2976ee2 to 566e47e Compare June 13, 2026 09:43
@davidBar-On

Copy link
Copy Markdown
Contributor Author

Haven't quiet figured out how to deal with this yet.

I tested it by creating a version with HAVE_MSG_TRUNC set to zero, and then run it once as a client and once as a server (when the other side is the version with HAVE_MSG_TRUNC set to 1). I believe this is sufficient as each of these options affect either sending or sides but not both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zerocopy os check should wait for sever response when in reverse mode

2 participants