Skip to content

docs: clarify blank-line rule in admonition multi-line examples#3468

Open
cotti wants to merge 2 commits into
mainfrom
docs/admonition-multiline-blank-line-3131
Open

docs: clarify blank-line rule in admonition multi-line examples#3468
cotti wants to merge 2 commits into
mainfrom
docs/admonition-multiline-blank-line-3131

Conversation

@cotti
Copy link
Copy Markdown
Contributor

@cotti cotti commented Jun 4, 2026

Why

Closes #3131. The admonitions page claims callouts "can span multiple lines and support inline formatting," but the Plain example reproduced the exact misleading pattern that confused authors: its content reads "It can span multiple lines…" yet sits on a single line with no blank line, so it renders as one paragraph. The page also never stated the standard Markdown rule that adjacent lines collapse into one paragraph.

#3129 already corrected the Note example; this finishes the remaining gap.

What

  • Added a blank line inside the Plain example (both the Output and Markdown tabs) so it actually renders as two paragraphs, mirroring the Note fix.
  • Added one sentence near the top of "Basic admonitions" explaining that paragraphs inside an admonition must be separated by a blank line.

Made with Cursor

Fix the Plain admonition example so it actually renders multiple
lines, and spell out that paragraphs inside an admonition must be
separated by a blank line.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cotti cotti requested a review from a team as a code owner June 4, 2026 23:15
@cotti cotti added the documentation Improvements or additions to documentation label Jun 4, 2026
@cotti cotti requested a review from a team as a code owner June 4, 2026 23:15
@cotti cotti added the documentation Improvements or additions to documentation label Jun 4, 2026
@cotti cotti requested a review from Mpdreamz June 4, 2026 23:15
@cotti cotti temporarily deployed to integration-tests June 4, 2026 23:15 — with GitHub Actions Inactive
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes.

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the admonitions documentation to clarify multi-line formatting support. The Plain admonition example is expanded by adding a sample content line ("This is a plain callout.") to both the rendered output example and the corresponding Markdown code block, demonstrating how multi-line content works in practice. A minor trailing whitespace adjustment is also made to the Basic admonitions intro text.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: clarifying the blank-line rule in admonition multi-line examples, which is the core fix in this PR.
Description check ✅ Passed The description is well-detailed and directly related to the changeset, explaining the problem with the Plain example and the solution applied.
Linked Issues check ✅ Passed The PR successfully addresses the objectives from #3131 by adding a blank line to the Plain example and clarifying the blank-line rule in the documentation.
Out of Scope Changes check ✅ Passed All changes are scoped to the admonitions documentation and directly address the issue raised in #3131; no unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch docs/admonition-multiline-blank-line-3131

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread docs/syntax/admonitions.md Outdated
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/syntax/admonitions.md`:
- Around line 7-8: The intro to the Admonitions doc is missing the explicit rule
that paragraphs inside an admonition must be separated by a blank line; update
the sentence immediately after "Admonitions can span multiple lines and support
inline formatting." to add a clear rule like "Separate paragraphs inside an
admonition with a blank line." so readers know to insert an empty line between
paragraphs; keep the wording concise and mirror the tone of the existing intro
so it reads as a single, authoritative rule.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3cf6a341-f7d5-431c-9a88-fa014f479f94

📥 Commits

Reviewing files that changed from the base of the PR and between 667e2ec and 3c11ef3.

📒 Files selected for processing (1)
  • docs/syntax/admonitions.md

Comment on lines +7 to +8
Admonitions can span multiple lines and support inline formatting.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add the explicit blank-line rule to match the intended behavior

The new example is fixed, but the intro still doesn’t state the key rule: separate paragraphs inside an admonition with a blank line. Without that sentence, the original confusion from #3131 can still recur.

Suggested doc patch
-Admonitions can span multiple lines and support inline formatting. 
+Admonitions can span multiple lines and support inline formatting.
+To create multiple paragraphs inside an admonition, separate them with a blank line.

Based on learnings: "Update /docs/ whenever Markdown syntax or rendering behaviour changes."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Admonitions can span multiple lines and support inline formatting.
Admonitions can span multiple lines and support inline formatting.
To create multiple paragraphs inside an admonition, separate them with a blank line.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/syntax/admonitions.md` around lines 7 - 8, The intro to the Admonitions
doc is missing the explicit rule that paragraphs inside an admonition must be
separated by a blank line; update the sentence immediately after "Admonitions
can span multiple lines and support inline formatting." to add a clear rule like
"Separate paragraphs inside an admonition with a blank line." so readers know to
insert an empty line between paragraphs; keep the wording concise and mirror the
tone of the existing intro so it reads as a single, authoritative rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Admonition documentation does not clearly support multi-line/formatting use, causing confusion

2 participants