Skip to content

Removing deprecated search label#3458

Open
jilldoty-elastic wants to merge 1 commit into
mainfrom
cleanup_search_label
Open

Removing deprecated search label#3458
jilldoty-elastic wants to merge 1 commit into
mainfrom
cleanup_search_label

Conversation

@jilldoty-elastic
Copy link
Copy Markdown

@jilldoty-elastic jilldoty-elastic commented Jun 2, 2026

Tiny change to remove reference to deprecated :Search/Search label.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b557dc78-af46-4fee-851f-a192aae4cffe

📥 Commits

Reviewing files that changed from the base of the PR and between e010a12 and 178edcf.

📒 Files selected for processing (1)
  • docs/contribute/configure-changelogs-ref.md

📝 Walkthrough

Walkthrough

Documentation reference updates to configure-changelogs-ref.md. The pivot.areas example now demonstrates a GitHub label mapping using Search Relevance instead of Search. Formatting around the rules.bundle section adjusted for spacing clarity. Both changes are isolated to a single documentation file with no impact on code or public entities.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing a deprecated search label from the documentation.
Description check ✅ Passed The description directly relates to the changeset, explaining the removal of a deprecated :Search/Search label reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch cleanup_search_label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

| Setting | Description |
| ----------------- | ------------------------------------------ |
| `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search": ":Search/Search"`). |
| `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search Relevance": ":Search Relevance/Search"`). |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on your other change, I think this is wrong

Suggested change
| `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search Relevance": ":Search Relevance/Search"`). |
| `pivot.areas` | Lists the valid area values. Optionally maps area names to GitHub labels (for example, `"Search": ":Search Relevance/Search"`). |

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to remove the catch-all "Search" label - you have to be more specific now. "Search" should not map to "Search Relevance" - I just wanted to leave an example in this documentation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I want @lcawl or @cotti to weigh in here because I don't know how these are used.

fwiw, your change in the other PR does map search directly to relevance. if that's not what you want, you probably need to make some further changes.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, the other maps the general Search area to "Search Foundations" - it's the closest to the original purpose. I was concerned that removing it all together would break something.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, reading too fast. will leave this for the others regardless :)

@shainaraskas shainaraskas added the documentation Improvements or additions to documentation label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants