feat: blocklist to revoke jwt tokens after logout - #325
Open
MaferMazu wants to merge 4 commits into
Open
Conversation
|
|
||
|
|
||
| def view_auth_classes(is_user=False, is_authenticated=True): | ||
| def view_auth_classes(is_user=False, is_authenticated=True, jwt_authentication_class=BlocklistJwtAuthentication): |
Member
There was a problem hiding this comment.
esto esta raro, no te parece? Perfectamente podríamos poner la clase BlocklistJwtAuthentication en la línea 123 directo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a security report regarding stateless JWTs remaining valid after user logout. Although the session is invalidated on logout, active JWTs could still be re-used via API calls (e.g., via curl).
To address this, we implemented a custom JWT blocklist mechanism stored in cache to revoke tokens upon logout forcibly.
Changes:
Note: This change is not needed in upstream. There is an ADR about it: https://github.com/openedx/openedx-platform/blob/master/openedx/core/djangoapps/oauth_dispatch/docs/decisions/0009-jwt-in-session-cookie.rst. But for stricter access, we implement this for a specific client.
How to Test