fix(envd): fix process lookup by tag and nil panic in Wait()#3140
Open
AdaAibaby wants to merge 1 commit into
Open
fix(envd): fix process lookup by tag and nil panic in Wait()#3140AdaAibaby wants to merge 1 commit into
AdaAibaby wants to merge 1 commit into
Conversation
Two bugs in the process service: 1. getProcess Range callback return values were inverted: - Returned true (continue) on match — should return false (stop) - Returned false (stop) on non-match — should return true (continue) This caused tag-based process lookup to fail randomly: it would stop at the first non-matching tagged process instead of continuing to search, and would keep iterating after finding a match. 2. Handler.Wait() unconditionally called p.tty.Close(), but p.tty is nil for non-PTY processes (those started via cmd.Start() at line 429). Every non-PTY process exit would panic with a nil pointer dereference.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a nil check before closing the terminal tty in the process handler to prevent potential nil pointer dereferences, and corrects the boolean return values in the process service's iteration loop to ensure the search terminates correctly once a matching process is found. No further feedback or issues were identified.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the process service:
getProcess Range callback return values were inverted:
Handler.Wait() unconditionally called p.tty.Close(), but p.tty is nil for non-PTY processes (those started via cmd.Start() at line 429). Every non-PTY process exit would panic with a nil pointer dereference.
/cc @jakubno @dobrac @ValentaTomas Would appreciate your review on this change, thanks!