Skip to content

fix(envd): fix process lookup by tag and nil panic in Wait()#3140

Open
AdaAibaby wants to merge 1 commit into
e2b-dev:mainfrom
AdaAibaby:fix/envd-process-bugs
Open

fix(envd): fix process lookup by tag and nil panic in Wait()#3140
AdaAibaby wants to merge 1 commit into
e2b-dev:mainfrom
AdaAibaby:fix/envd-process-bugs

Conversation

@AdaAibaby

@AdaAibaby AdaAibaby commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Two bugs in the process service:

  1. getProcess Range callback return values were inverted:

    • Returned true (continue) on match — should return false (stop)
    • Returned false (stop) on non-match — should return true (continue) This caused tag-based process lookup to fail randomly: it would stop at the first non-matching tagged process instead of continuing to search, and would keep iterating after finding a match.
  2. Handler.Wait() unconditionally called p.tty.Close(), but p.tty is nil for non-PTY processes (those started via cmd.Start() at line 429). Every non-PTY process exit would panic with a nil pointer dereference.

/cc @jakubno @dobrac @ValentaTomas Would appreciate your review on this change, thanks!

Two bugs in the process service:

1. getProcess Range callback return values were inverted:
   - Returned true (continue) on match — should return false (stop)
   - Returned false (stop) on non-match — should return true (continue)
   This caused tag-based process lookup to fail randomly: it would stop
   at the first non-matching tagged process instead of continuing to
   search, and would keep iterating after finding a match.

2. Handler.Wait() unconditionally called p.tty.Close(), but p.tty is
   nil for non-PTY processes (those started via cmd.Start() at line 429).
   Every non-PTY process exit would panic with a nil pointer dereference.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a nil check before closing the terminal tty in the process handler to prevent potential nil pointer dereferences, and corrects the boolean return values in the process service's iteration loop to ensure the search terminates correctly once a matching process is found. No further feedback or issues were identified.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants