fix: handle InvalidObjectState error for archived S3 objects

[gaomingxing]

Summary

When objects are transitioned to archived storage classes (e.g. GLACIER, ARCHIVE_FR, COLD_ARCHIVE) via lifecycle rules, S3-compatible backends return an InvalidObjectState error on GetObject/HeadObject instead of the usual NoSuchKey. Previously this was unhandled, causing sandbox creation to fail with a generic "Internal" gRPC error.

Changes

packages/shared/pkg/storage/storage.go

• Added ErrObjectArchived sentinel error for archived/inaccessible objects

packages/shared/pkg/storage/storage_aws.go

• WriteTo(): handle types.InvalidObjectState → ErrObjectArchived
• OpenRangeReader(): handle types.InvalidObjectState → ErrObjectArchived
• Size(): handle types.InvalidObjectState → ErrObjectArchived

packages/shared/pkg/storage/metrics.go

• Added OutcomeArchived constant for metrics tracking
• Outcome() function now maps ErrObjectArchived to the "archived" outcome

packages/orchestrator/pkg/server/sandboxes.go

• Create(): check for ErrObjectArchived and return FailedPrecondition with a clear message telling users to rebuild the template

Testing

• Verified compilation of both shared/pkg/storage and orchestrator/pkg/server packages
• The InvalidObjectState error type is part of the AWS SDK v2 (github.com/aws/aws-sdk-go-v2/service/s3/types) and is returned when attempting to read objects in GLACIER, ARCHIVE, or similar storage classes

Closes #3137

[gemini-code-assist]

Code Review

This pull request introduces handling for archived storage objects by defining a new error ErrObjectArchived and its corresponding metric outcome OutcomeArchived. It updates AWS storage operations to detect types.InvalidObjectState errors and wrap them as ErrObjectArchived, and updates the orchestrator's sandbox creation logic to handle this error by reporting it to telemetry and returning a failed precondition status. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.