feat(templates): improve highlight date and time in template list created/updated column#484
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ated/updated column
Kraci
force-pushed
the
smartly-highlight-date-and-time-in-template-list-en-1151
branch
from
122e357 to
dbd77cb
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 122e357cd4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const datePart = formatted?.datePart | ||
|
|
||
| const isTimePromoted = useMemo(() => { | ||
| if (!isSortedColumn || !datePart) return false |
There was a problem hiding this comment.
When the table is sorted by Updated (the default), isSortedColumn is false for every Created cell, so the same-day check is skipped even if the Created dates of the rows immediately above or below match; sorting by Created has the symmetric problem for Updated. Since the new highlighting is meant to apply to the Created/Updated date cells based on adjacent rows, this leaves one of the two columns permanently in the default tertiary time style.
Useful? React with 👍 / 👎.
1 participant
Improve highlighting of the date and time in the Created/Updated columns of the Templates list to better visually group rows by day.
Why?
Templates are usually updated infrequently, so highlighting the date makes more sense. However, some teams create and update many templates.
Highlight rules