Skip to content

Allow setting sandbox start params in dashboard terminal en 1363#479

Draft
matthewlouisbrockman wants to merge 9 commits into
mainfrom
allow-setting-sandbox-start-params-in-dashboard-terminal-en-1363
Draft

Allow setting sandbox start params in dashboard terminal en 1363#479
matthewlouisbrockman wants to merge 9 commits into
mainfrom
allow-setting-sandbox-start-params-in-dashboard-terminal-en-1363

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

No description provided.

@linear-code

linear-code Bot commented Jun 30, 2026

Copy link
Copy Markdown

EN-1363

@cla-bot cla-bot Bot added the cla-signed label Jun 30, 2026
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 30, 2026 2:18am

Request Review

@cursor

cursor Bot commented Jun 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
PTY user and environment variables affect sandbox process context; URL-driven values require explicit confirmation but misconfiguration could still change runtime behavior on reconnect.

Overview
Dashboard terminal and sandbox terminal accept user, cwd, and repeated env query params; /dashboard?tab=terminal and sign-in return URLs preserve them. Those params become TerminalPtyOptions on launch, and presence of any PTY param forces a confirmation step before connect (command optional).

PTY create no longer hardcodes /home/user; options from stored defaults (cookie on sandbox terminal), launch target, or the PTY settings UI are spread into sandbox.pty.create. Sandbox-scoped terminal enables configure-PTY in the panel and reconnect on apply.

Browser envd clients rewrite sandboxUrl to the 49983-{sandboxId}. host prefix via resolveBrowserSandboxUrl.

Reviewed by Cursor Bugbot for commit 632be5b. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0549cc6. Configure here.

Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant