fix: improve hover state for the webhooks list#478
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96d025a85d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — visual-only refactor of the webhooks list, swapping the HTML table for the flex-based DataTable primitive to improve hover styling.
Extended reasoning...
Overview
This PR is a presentation-only refactor of the webhooks settings list. It swaps the semantic HTML Table/TableRow/TableCell primitives for the flex-based DataTable/DataTableRow components, reworks the row hover state (background, border masking, hover frame), and inlines a small placeholder component for the loading and empty states.
Security risks
None. There are no changes to auth, data fetching, query construction, or user input handling. All modifications are confined to JSX structure and Tailwind class names within an already-protected dashboard route.
Level of scrutiny
Low. The diff touches only three UI files under src/features/dashboard/settings/webhooks/ (no shared components or owned modules), the imported DataTable/DataTableRow and supporting primitives all exist in the repo, and a Vercel preview deployment is already live for visual verification. Linear ticket EN-1140 is linked.
Other factors
The bug hunting system found no issues. The change is small, self-contained, and the before/after screenshots in the description document the intended visual improvement.
Kraci
force-pushed
the
fix-hover-on-webhooks-page-en-1140
branch
from
96d025a to
2a860c7
Compare
Kraci
force-pushed
the
fix-hover-on-webhooks-page-en-1140
branch
from
2a860c7 to
e7815e6
Compare
|
nit but we should probably keep hover consistent with other tables and make it work over whole item width |
2 participants
Improve hover state for the webhooks list